Skip to content

Commit b462288

Browse files
committed
Port the truncate sort order tests from the Java reference implementation
Mirror TestSortOrder#testSatisfiesTruncateFieldOrder at the transform level, since pyiceberg has no SortOrder.satisfies. Generated-by: AI-assisted
1 parent 4e6ecc7 commit b462288

1 file changed

Lines changed: 16 additions & 6 deletions

File tree

‎tests/test_transforms.py‎

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -513,12 +513,22 @@ def test_truncate_method(type_var: PrimitiveType, value: Any, expected_human_str
513513
assert truncate_transform.satisfies_order_of(truncate_transform)
514514

515515

516-
def test_truncate_satisfies_order_of_different_widths() -> None:
517-
assert TruncateTransform(3).satisfies_order_of(TruncateTransform(3))
518-
assert TruncateTransform(5).satisfies_order_of(TruncateTransform(3))
519-
assert not TruncateTransform(3).satisfies_order_of(TruncateTransform(5))
520-
assert not TruncateTransform(3).satisfies_order_of(IdentityTransform())
521-
assert not TruncateTransform(3).satisfies_order_of(BucketTransform(3))
516+
# Ported from TestSortOrder#testSatisfiesTruncateFieldOrder in the Java reference implementation:
517+
# https://github.com/apache/iceberg/blob/main/core/src/test/java/org/apache/iceberg/TestSortOrder.java
518+
@pytest.mark.parametrize(
519+
"transform,other,expected",
520+
[
521+
(IdentityTransform(), TruncateTransform(2), True),
522+
(TruncateTransform(2), IdentityTransform(), False),
523+
(TruncateTransform(4), IdentityTransform(), False),
524+
(TruncateTransform(4), TruncateTransform(2), True),
525+
(TruncateTransform(2), TruncateTransform(4), False),
526+
(TruncateTransform(2), TruncateTransform(2), True),
527+
(TruncateTransform(3), BucketTransform(3), False),
528+
],
529+
)
530+
def test_truncate_satisfies_order_of(transform: Transform[Any, Any], other: Transform[Any, Any], expected: bool) -> None:
531+
assert transform.satisfies_order_of(other) is expected
522532

523533

524534
def test_unknown_transform() -> None:

0 commit comments

Comments
 (0)