Repository navigation
Commit 68c7ca2
committed
Keep rows where a delete filter evaluates to null
delete() and overwrite() rewrite a data file with the rows the delete
filter does not select. The complementary filter was Not(filter) OR'd
with IS NULL for each column the filter does not null-check, so a null
kept rows the filter matches (p == 1 OR v == 'c' with a null v) and
dropped rows it does not match, where Not(filter) is null.
Coalesce the filter to false before inverting it, so exactly the rows
where the filter is true are deleted, the rows scan(row_filter=filter)
returns.
Closes #41841 parent 06a529d commit 68c7ca2
3 files changed
Lines changed: 37 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
69 | 69 | | |
70 | 70 | | |
71 | 71 | | |
72 | | - | |
| 72 | + | |
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
| |||
1125 | 1125 | | |
1126 | 1126 | | |
1127 | 1127 | | |
1128 | | - | |
| 1128 | + | |
| 1129 | + | |
1129 | 1130 | | |
1130 | 1131 | | |
1131 | 1132 | | |
1132 | 1133 | | |
1133 | 1134 | | |
1134 | | - | |
1135 | | - | |
1136 | | - | |
1137 | 1135 | | |
1138 | 1136 | | |
1139 | 1137 | | |
1140 | 1138 | | |
1141 | | - | |
1142 | | - | |
1143 | | - | |
| 1139 | + | |
| 1140 | + | |
1144 | 1141 | | |
1145 | | - | |
1146 | | - | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
1147 | 1146 | | |
1148 | 1147 | | |
1149 | 1148 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1295 | 1295 | | |
1296 | 1296 | | |
1297 | 1297 | | |
| 1298 | + | |
| 1299 | + | |
| 1300 | + | |
| 1301 | + | |
| 1302 | + | |
| 1303 | + | |
| 1304 | + | |
| 1305 | + | |
| 1306 | + | |
| 1307 | + | |
| 1308 | + | |
| 1309 | + | |
| 1310 | + | |
| 1311 | + | |
| 1312 | + | |
| 1313 | + | |
| 1314 | + | |
| 1315 | + | |
| 1316 | + | |
| 1317 | + | |
| 1318 | + | |
| 1319 | + | |
| 1320 | + | |
| 1321 | + | |
| 1322 | + | |
1298 | 1323 | | |
1299 | 1324 | | |
1300 | 1325 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
856 | 856 | | |
857 | 857 | | |
858 | 858 | | |
859 | | - | |
| 859 | + | |
860 | 860 | | |
861 | | - | |
862 | | - | |
863 | | - | |
| 861 | + | |
| 862 | + | |
864 | 863 | | |
865 | 864 | | |
0 commit comments