Skip to content

Commit 3af1a3e

Browse files
kevinjqliuCopilot
andcommitted
Simplify parametrize guidance in AGENTS.md
Scope the loop preference to many simple cases and note when parametrize or separate tests fit better. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent 93e6be0 commit 3af1a3e

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

‎AGENTS.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ lives under `pyiceberg/`, organized by concern rather than by engine:
6565
- Bias towards adding tests to existing files, rather than creating new files.
6666
- Use existing test fixtures when possible.
6767
- We have a strong bias towards integration testing over mocks. Mocks should be avoided whenever possible and should only be used if similar, existing tests are using mocks.
68-
- Prefer a `for` loop in a single test over `@pytest.mark.parametrize`; each parametrized case adds per-test overhead that slows the suite. Include the input in assertion messages so failures are identifiable. Use `parametrize` only when cases need different fixtures (e.g., multiple catalogs).
68+
- Prefer a `for` loop over `@pytest.mark.parametrize` for many simple cases; each parametrized case adds per-test overhead. Use `parametrize` when cases need different fixtures, and separate tests when cases are complex.
6969

7070
### Required CI and Merge Queue
7171

0 commit comments

Comments
 (0)