Skip to content

Commit ff317b3

Browse files
style(view): use emplace_back for representations
1 parent 63fc9d7 commit ff317b3

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

‎src/iceberg/test/view_metadata_test.cc‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ TEST(ViewMetadataTest, ValidateAcceptsValidMetadata) {
8989

9090
TEST(ViewMetadataTest, ValidateAcceptsUnknownRepresentation) {
9191
ViewMetadata metadata = MakeValidMetadata();
92-
metadata.versions[0]->representations.push_back(
92+
metadata.versions[0]->representations.emplace_back(
9393
UnknownViewRepresentation{.type = "cypher"});
9494
EXPECT_THAT(metadata.Validate(), IsOk());
9595
}
@@ -262,12 +262,12 @@ TEST(ViewMetadataTest, EqualityComparesAllFields) {
262262
EXPECT_NE(lhs, rhs);
263263

264264
ViewMetadata changed = MakeValidMetadata();
265-
changed.versions[0]->representations.push_back(
265+
changed.versions[0]->representations.emplace_back(
266266
UnknownViewRepresentation{.type = "cypher"});
267267
EXPECT_NE(lhs, changed);
268268

269269
ViewMetadata unknown = lhs;
270-
unknown.versions[0]->representations.push_back(
270+
unknown.versions[0]->representations.emplace_back(
271271
UnknownViewRepresentation{.type = "cypher"});
272272
EXPECT_EQ(unknown, changed);
273273
}

0 commit comments

Comments
 (0)