Repository navigation
Commit a2bbf18
Minh Vu
fix: validate truncate widths in utility entrypoints (#739)
## Summary
- Reject non-positive widths in the `TruncateLiteral` and
`TruncateLiteralMax` utility entrypoints.
- Reject zero width in `TruncateUTF8Max`, which returns a `Result` and
can report invalid input directly.
- Add regression coverage for zero and negative widths across numeric,
decimal, string, and binary literal truncation.
## Why
The truncate transform validates its width before creating a transform
function, but the utility functions can also be called directly. Without
a guard there, invalid widths can reach modulo operations or iterator
arithmetic in the type-specific implementations.
## Testing
- `cmake --build build --target util_test`
- `ctest --test-dir build -R util_test --output-on-failure`1 parent fc9781f commit a2bbf18
2 files changed
Lines changed: 63 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
54 | 74 | | |
55 | 75 | | |
56 | 76 | | |
| |||
190 | 210 | | |
191 | 211 | | |
192 | 212 | | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
193 | 235 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
| |||
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
37 | 52 | | |
38 | 53 | | |
39 | 54 | | |
| |||
205 | 220 | | |
206 | 221 | | |
207 | 222 | | |
| 223 | + | |
| 224 | + | |
208 | 225 | | |
209 | 226 | | |
210 | 227 | | |
| |||
253 | 270 | | |
254 | 271 | | |
255 | 272 | | |
| 273 | + | |
| 274 | + | |
256 | 275 | | |
257 | 276 | | |
258 | 277 | | |
| |||
280 | 299 | | |
281 | 300 | | |
282 | 301 | | |
| 302 | + | |
| 303 | + | |
283 | 304 | | |
284 | 305 | | |
285 | 306 | | |
| |||
0 commit comments