Skip to content

Commit 52b0200

Browse files
manuzhangclaude
andcommitted
ci: enforce standard-library includes with misc-include-cleaner
Re-enable clang-tidy's misc-include-cleaner, scoped to standard-library headers only. Project headers under iceberg/ and all third-party headers are listed in IgnoreHeaders, so the check no longer demands a direct include for every symbol an already-included project header provides, which is the noise that led to its removal in #708. What remains is the class of regression seen in #1066: a source file drops <vector> or <memory> while still using std::vector or std::unique_ptr, and compiles only because a project header happens to pull the standard header in transitively. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
1 parent 49f8a87 commit 52b0200

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

‎.clang-tidy‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ Checks: |
2121
clang-analyzer-*,
2222
google-*,
2323
modernize-*,
24+
misc-include-cleaner,
2425
readability-identifier-naming,
2526
readability-isolate-declaration,
2627
-modernize-use-nodiscard,
@@ -41,5 +42,11 @@ CheckOptions:
4142
value: '_'
4243
- key: modernize-use-scoped-lock.WarnOnSingleLocks
4344
value: 'false'
45+
# misc-include-cleaner is scoped to standard-library headers only. Project
46+
# headers (iceberg/) and third-party headers are ignored so the check does
47+
# not demand a direct include for every symbol that an already-included
48+
# project header provides (the noise that led to its removal in #708).
49+
- key: misc-include-cleaner.IgnoreHeaders
50+
value: 'iceberg/.*;arrow/.*;avro/.*;aws/.*;benchmark/.*;cpr/.*;curl/.*;gmock/.*;gtest/.*;nanoarrow/.*;nlohmann/.*;openssl/.*;parquet/.*;roaring/.*;spdlog/.*;sqlpp23/.*;thrift/.*;libpq-fe\.h;mysql\.h;sqlite3\.h;utf8proc\.h;zlib\.h'
4451

4552
HeaderFilterRegex: 'src/iceberg|example'

0 commit comments

Comments
 (0)