From b166dee7f1921567d42c6b1da2f1263c888207a8 Mon Sep 17 00:00:00 2001 From: Kumar Ujjawal Date: Thu, 19 Nov 2026 11:06:05 +0530 Subject: [PATCH 1/2] ci: set job timeouts for GitHub Actions --- .github/workflows/audit.yml | 1 + .../workflows/breaking_changes_detector.yml | 1 + .../breaking_changes_detector_comment.yml | 1 + .github/workflows/codeql.yml | 1 + .github/workflows/dependencies.yml | 1 + .github/workflows/dev.yml | 5 ++++ .github/workflows/docs.yaml | 1 + .github/workflows/docs_pr.yaml | 1 + .github/workflows/docs_versions.yaml | 1 + .github/workflows/extended.yml | 3 +++ .github/workflows/labeler.yml | 1 + .github/workflows/large_files.yml | 1 + .github/workflows/pull_request_signal.yml | 1 + .../workflows/release_version_labeler.yaml | 1 + .github/workflows/rust.yml | 27 +++++++++++++++++++ .github/workflows/stale.yml | 1 + .github/workflows/take.yml | 1 + docs/source/contributor-guide/index.md | 12 +++++++++ 18 files changed, 61 insertions(+) diff --git a/.github/workflows/audit.yml b/.github/workflows/audit.yml index 428c15cb13b19..8cbb1d03e5605 100644 --- a/.github/workflows/audit.yml +++ b/.github/workflows/audit.yml @@ -29,6 +29,7 @@ permissions: jobs: security_audit: runs-on: ubuntu-slim + timeout-minutes: 10 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Setup Rust toolchain diff --git a/.github/workflows/breaking_changes_detector.yml b/.github/workflows/breaking_changes_detector.yml index f2ff45a508f9e..6d9d52849aa38 100644 --- a/.github/workflows/breaking_changes_detector.yml +++ b/.github/workflows/breaking_changes_detector.yml @@ -41,6 +41,7 @@ jobs: check-semver: name: Check semver runs-on: ubuntu-latest + timeout-minutes: 45 steps: # The checkout is GitHub's test merge commit of the PR into the base # branch. Depth 2 fetches that commit and its two parents: the base diff --git a/.github/workflows/breaking_changes_detector_comment.yml b/.github/workflows/breaking_changes_detector_comment.yml index a67177149f690..851236e67f6f0 100644 --- a/.github/workflows/breaking_changes_detector_comment.yml +++ b/.github/workflows/breaking_changes_detector_comment.yml @@ -49,6 +49,7 @@ jobs: name: Comment on pull request if: github.event.workflow_run.event == 'pull_request' runs-on: ubuntu-slim + timeout-minutes: 10 # Scoped to the minimum needed to upsert/delete the sticky comment. permissions: actions: read diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 2543ba6db0706..35c78d7db0d0f 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -19,6 +19,7 @@ jobs: analyze: name: Analyze Actions runs-on: ubuntu-slim + timeout-minutes: 10 permissions: contents: read security-events: write diff --git a/.github/workflows/dependencies.yml b/.github/workflows/dependencies.yml index 36c4aeae29efc..77a18b837e6f8 100644 --- a/.github/workflows/dependencies.yml +++ b/.github/workflows/dependencies.yml @@ -30,6 +30,7 @@ jobs: detect-unused-dependencies: name: Detect Unused Dependencies runs-on: ${{ github.event_name == 'merge_group' && vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=2,image=ubuntu24-full-x64,tag=datafusion', github.run_id) || 'ubuntu-slim' }} + timeout-minutes: 10 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Setup Rust toolchain diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml index 6601eb30c151f..d35a255a59f15 100644 --- a/.github/workflows/dev.yml +++ b/.github/workflows/dev.yml @@ -25,6 +25,7 @@ concurrency: jobs: license-header-check: runs-on: &small-runner ${{ github.event_name == 'merge_group' && vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=2,image=ubuntu24-full-x64,tag=datafusion', github.run_id) || 'ubuntu-slim' }} + timeout-minutes: 10 name: Check License Header steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 @@ -38,6 +39,7 @@ jobs: prettier: name: Use prettier to check formatting of documents runs-on: *small-runner + timeout-minutes: 10 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - uses: actions/setup-node@949feb2413d6458794dcd2491c4babbbce0c15c1 # v7.1.0 @@ -50,6 +52,7 @@ jobs: markdown-link-check: name: Check Markdown Links runs-on: *small-runner + timeout-minutes: 10 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Load tool versions @@ -66,6 +69,7 @@ jobs: asf-yaml-check: name: Validate required_status_checks in .asf.yaml runs-on: *small-runner + timeout-minutes: 10 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - run: pip install pyyaml @@ -80,6 +84,7 @@ jobs: typos: name: Spell Check with Typos runs-on: *small-runner + timeout-minutes: 10 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 with: diff --git a/.github/workflows/docs.yaml b/.github/workflows/docs.yaml index c9228f60378ab..0694c597f3678 100644 --- a/.github/workflows/docs.yaml +++ b/.github/workflows/docs.yaml @@ -24,6 +24,7 @@ jobs: contents: write name: Build docs runs-on: ubuntu-slim + timeout-minutes: 15 steps: - name: Checkout docs sources uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 diff --git a/.github/workflows/docs_pr.yaml b/.github/workflows/docs_pr.yaml index fcf5ade850d21..56f3900a09209 100644 --- a/.github/workflows/docs_pr.yaml +++ b/.github/workflows/docs_pr.yaml @@ -33,6 +33,7 @@ jobs: linux-test-doc-build: name: Test doc build runs-on: ubuntu-slim + timeout-minutes: 15 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 with: diff --git a/.github/workflows/docs_versions.yaml b/.github/workflows/docs_versions.yaml index 33b79d4d85711..8d436e90d9506 100644 --- a/.github/workflows/docs_versions.yaml +++ b/.github/workflows/docs_versions.yaml @@ -37,6 +37,7 @@ jobs: contents: write name: Build versioned docs runs-on: ubuntu-slim + timeout-minutes: 15 steps: - name: Checkout docs sources uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 diff --git a/.github/workflows/extended.yml b/.github/workflows/extended.yml index c82e7fc8586a3..5085ad49846f1 100644 --- a/.github/workflows/extended.yml +++ b/.github/workflows/extended.yml @@ -45,6 +45,7 @@ jobs: # Long-running job: run in the merge queue, on release pushes, or manually. if: github.event_name != 'pull_request' runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=32,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 90 # note: do not use amd/rust container to preserve disk space steps: - uses: runs-on/action@4a3bfc79f21a9b97e972e2ba75a2b0b1e9688670 # v2.7.1 @@ -93,6 +94,7 @@ jobs: # Long-running job: run in the merge queue, on release pushes, or manually. if: github.event_name != 'pull_request' runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 60 container: image: amd64/rust steps: @@ -117,6 +119,7 @@ jobs: # Long-running job: run in the merge queue, on release pushes, or manually. if: github.event_name != 'pull_request' runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=32,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 90 container: image: amd64/rust steps: diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml index 295704094462f..9215b8ef3e884 100644 --- a/.github/workflows/labeler.yml +++ b/.github/workflows/labeler.yml @@ -22,6 +22,7 @@ jobs: process: name: Process runs-on: ubuntu-slim + timeout-minutes: 10 if: github.event.workflow_run.event == 'pull_request' # The token of a `workflow_run` workflow can update PRs from forks. # Previously `pull_request_target` was used for the same reason, see diff --git a/.github/workflows/large_files.yml b/.github/workflows/large_files.yml index 87c73fe8a5260..1b1bd0c14f59e 100644 --- a/.github/workflows/large_files.yml +++ b/.github/workflows/large_files.yml @@ -18,6 +18,7 @@ permissions: jobs: check-files: runs-on: ubuntu-slim + timeout-minutes: 10 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 with: diff --git a/.github/workflows/pull_request_signal.yml b/.github/workflows/pull_request_signal.yml index e1d1e15e85e67..9c9f4d95dffba 100644 --- a/.github/workflows/pull_request_signal.yml +++ b/.github/workflows/pull_request_signal.yml @@ -38,5 +38,6 @@ jobs: signal: name: Signal pull request update runs-on: ubuntu-slim + timeout-minutes: 10 steps: - run: echo "This run triggers the workflow_run workflows that handle the pull request." diff --git a/.github/workflows/release_version_labeler.yaml b/.github/workflows/release_version_labeler.yaml index 10127e45ea7cf..11c442d37a0e8 100644 --- a/.github/workflows/release_version_labeler.yaml +++ b/.github/workflows/release_version_labeler.yaml @@ -21,6 +21,7 @@ jobs: # A fork that syncs its main branch also gets this push, and has nothing to label. if: github.repository == 'apache/datafusion' runs-on: ubuntu-slim + timeout-minutes: 10 permissions: pull-requests: write contents: read diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 30094c07c7c99..134ec4cc6eb34 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -79,6 +79,7 @@ jobs: name: linux build test if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=8,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 45 container: image: amd64/rust steps: @@ -130,6 +131,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: &xlarge-runner ${{ github.event_name == 'merge_group' && vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a,cpu=4,image=ubuntu24-full-x64,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 15 container: image: amd64/rust steps: @@ -163,6 +165,7 @@ jobs: env: CARGO_INCREMENTAL: "0" runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 30 container: image: amd64/rust steps: @@ -209,6 +212,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 30 container: image: amd64/rust steps: @@ -246,6 +250,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 30 container: image: amd64/rust steps: @@ -275,6 +280,7 @@ jobs: env: CARGO_INCREMENTAL: "0" runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 30 container: image: amd64/rust steps: @@ -349,6 +355,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: *xlarge-runner + timeout-minutes: 30 container: image: amd64/rust steps: @@ -391,6 +398,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 90 container: image: amd64/rust volumes: @@ -457,6 +465,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 30 steps: - uses: runs-on/action@4a3bfc79f21a9b97e972e2ba75a2b0b1e9688670 # v2.7.1 - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 @@ -496,6 +505,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 60 container: image: amd64/rust steps: @@ -528,6 +538,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 30 container: image: amd64/rust steps: @@ -551,6 +562,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 30 container: image: amd64/rust steps: @@ -567,6 +579,7 @@ jobs: name: build and run with wasm-pack if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: ubuntu-24.04 + timeout-minutes: 30 env: # Use the preinstalled Clang 18 even if the runner's default Clang changes. CC_wasm32_unknown_unknown: clang-18 @@ -599,6 +612,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 45 container: image: amd64/rust steps: @@ -632,6 +646,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 30 container: image: amd64/rust services: @@ -670,6 +685,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 30 container: image: amd64/rust steps: @@ -719,6 +735,7 @@ jobs: name: cargo test (macos-aarch64) if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') && !(github.repository != 'apache/datafusion') }} runs-on: macos-15 + timeout-minutes: 60 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 with: @@ -734,6 +751,7 @@ jobs: name: Verify Vendored Code if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: &small-runner ${{ github.event_name == 'merge_group' && vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=2,image=ubuntu24-full-x64,tag=datafusion', github.run_id) || 'ubuntu-slim' }} + timeout-minutes: 10 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Setup Rust toolchain @@ -752,6 +770,7 @@ jobs: name: Check cargo fmt if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') }} runs-on: *small-runner + timeout-minutes: 10 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Setup Rust toolchain @@ -764,6 +783,7 @@ jobs: name: Check GitHub Actions install tooling if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') }} runs-on: *small-runner + timeout-minutes: 10 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Check workflow tool installs @@ -775,6 +795,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 60 container: image: amd64/rust steps: @@ -806,6 +827,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: *small-runner + timeout-minutes: 10 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 with: @@ -824,6 +846,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: ${{ vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=16,image=ubuntu24-full-x64,extras=s3-cache,disk=large,tag=datafusion', github.run_id) || 'ubuntu-latest' }} + timeout-minutes: 30 container: image: amd64/rust steps: @@ -854,6 +877,7 @@ jobs: needs: linux-build-lib if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: *xlarge-runner + timeout-minutes: 30 container: image: amd64/rust @@ -884,6 +908,7 @@ jobs: examples-check-datafusion-crates: name: Check datafusion crates used in datafusion-examples runs-on: *small-runner + timeout-minutes: 10 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - run: python3 ci/scripts/check_examples_datafusion_crates.py @@ -897,6 +922,7 @@ jobs: name: Verify MSRV (Min Supported Rust Version) if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: *xlarge-runner + timeout-minutes: 30 container: image: amd64/rust steps: @@ -949,6 +975,7 @@ jobs: name: Circular Dependency Check if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: *small-runner + timeout-minutes: 15 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Setup Rust toolchain diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml index 9480bb96d1de6..94370d321c91b 100644 --- a/.github/workflows/stale.yml +++ b/.github/workflows/stale.yml @@ -10,6 +10,7 @@ on: jobs: close-stale-prs: runs-on: ubuntu-slim + timeout-minutes: 10 permissions: actions: write issues: write diff --git a/.github/workflows/take.yml b/.github/workflows/take.yml index 311ec76523738..9f4d51848cdf9 100644 --- a/.github/workflows/take.yml +++ b/.github/workflows/take.yml @@ -13,6 +13,7 @@ permissions: jobs: issue_assign: runs-on: ubuntu-slim + timeout-minutes: 10 if: (!github.event.issue.pull_request) && (github.event.comment.body == 'take' || github.event.comment.body == 'untake') concurrency: group: ${{ github.actor }}-issue-assign diff --git a/docs/source/contributor-guide/index.md b/docs/source/contributor-guide/index.md index 1f468200fd0c9..16c4bdcda8b42 100644 --- a/docs/source/contributor-guide/index.md +++ b/docs/source/contributor-guide/index.md @@ -211,6 +211,18 @@ The automatic draft notification also counts as activity and restarts this timer ## CI Runners +### Job Timeouts + +Set `timeout-minutes` on every workflow job that runs on a runner. An explicit +limit stops a hung job before GitHub Actions' six-hour default. + +Use recent successful runs to choose a limit. Allow extra time for cold caches +and slower runners, including those used by forks. If a change increases a job's +expected runtime, adjust its limit in the same pull request. + +For reusable workflows, set the limit on jobs in the called workflow. The merge +queue has a separate deadline for required checks. + ### Runs-On We use [Runs-On](https://runs-on.com/) for some actions in the main repository, which run in the ASF AWS account to speed up CI. In forks, these actions run on the default GitHub runners since forks do not have access to ASF infrastructure. From bcbcc64870dfba19db0b7dacd837c8c9253b6773 Mon Sep 17 00:00:00 2001 From: Kumar Ujjawal Date: Thu, 19 Nov 2026 12:02:15 +0530 Subject: [PATCH 2/2] ci: raise limits for two slim-runner jobs to 15 minutes Verify Vendored Code and Detect Unused Dependencies took up to 6.6 and 6.1 minutes with warm caches, so 10 minutes left too little room. --- .github/workflows/dependencies.yml | 2 +- .github/workflows/rust.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/dependencies.yml b/.github/workflows/dependencies.yml index 77a18b837e6f8..f277e9b0cafc0 100644 --- a/.github/workflows/dependencies.yml +++ b/.github/workflows/dependencies.yml @@ -30,7 +30,7 @@ jobs: detect-unused-dependencies: name: Detect Unused Dependencies runs-on: ${{ github.event_name == 'merge_group' && vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=2,image=ubuntu24-full-x64,tag=datafusion', github.run_id) || 'ubuntu-slim' }} - timeout-minutes: 10 + timeout-minutes: 15 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Setup Rust toolchain diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 134ec4cc6eb34..643f7930d4fcf 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -751,7 +751,7 @@ jobs: name: Verify Vendored Code if: ${{ !(github.event_name == 'push' && github.ref == 'refs/heads/main' && github.repository == 'apache/datafusion') && !(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork && github.base_ref == 'main') }} runs-on: &small-runner ${{ github.event_name == 'merge_group' && vars.USE_RUNS_ON == 'true' && format('runs-on={0},family=m8a+m7a+c8a,cpu=2,image=ubuntu24-full-x64,tag=datafusion', github.run_id) || 'ubuntu-slim' }} - timeout-minutes: 10 + timeout-minutes: 15 steps: - uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 - name: Setup Rust toolchain