Rename supports_snowflake_pipe_operator to supports_long_arrow_pipe_operator

Author: BenSatori

src/dialect/generic.rs

@@ -320,4 +320,8 @@ impl Dialect for GenericDialect {
     fn supports_aliased_function_args(&self) -> bool {
         true
     }
+
+    fn supports_long_arrow_pipe_operator(&self) -> bool {
+        true
+    }
 }

src/dialect/mod.rs

@@ -726,11 +726,11 @@ pub trait Dialect: Debug + Any {
         false
     }
 
-    /// Does the dialect support the Snowflake `->>`  flow/pipe operator for chaining
-    /// SQL statements? e.g. `SELECT * FROM t ->> SELECT * FROM $1`
+    /// Does the dialect support the `->>` flow/pipe operator for chaining SQL statements?
+    /// e.g. `SELECT * FROM t ->> SELECT * FROM $1`
     ///
     /// See <https://docs.snowflake.com/en/sql-reference/operators-flow>
-    fn supports_snowflake_pipe_operator(&self) -> bool {
+    fn supports_long_arrow_pipe_operator(&self) -> bool {
         false
     }
 

src/dialect/snowflake.rs

@@ -694,7 +694,7 @@ impl Dialect for SnowflakeDialect {
         true
     }
 
-    fn supports_snowflake_pipe_operator(&self) -> bool {
+    fn supports_long_arrow_pipe_operator(&self) -> bool {
         true
     }
 

src/parser/mod.rs

@@ -629,7 +629,7 @@ impl<'a> Parser<'a> {
 
         // Handle Snowflake pipe operator: chain multiple statements with ->>
         // See <https://docs.snowflake.com/en/sql-reference/operators-flow>
-        if self.dialect.supports_snowflake_pipe_operator()
+        if self.dialect.supports_long_arrow_pipe_operator()
             && self.peek_token_ref().token == Token::LongArrow
         {
             let mut statements = vec![stmt];
@@ -13753,7 +13753,7 @@ impl<'a> Parser<'a> {
                 Token::EOF | Token::Eq | Token::SemiColon | Token::VerticalBarRightAngleBracket => {
                     break
                 }
-                Token::LongArrow if self.dialect.supports_snowflake_pipe_operator() => break,
+                Token::LongArrow if self.dialect.supports_long_arrow_pipe_operator() => break,
                 _ => {}
             }
             self.advance_token();
@@ -16738,7 +16738,7 @@ impl<'a> Parser<'a> {
         } else {
             // Handle Snowflake pipe result references ($1, $2, ...) in FROM clause.
             // See <https://docs.snowflake.com/en/sql-reference/operators-flow>
-            if self.dialect.supports_snowflake_pipe_operator() {
+            if self.dialect.supports_long_arrow_pipe_operator() {
                 if let Token::Placeholder(ref s) = self.peek_token_ref().token.clone() {
                     if let Some(index_str) = s.strip_prefix('$') {
                         if let Ok(index @ 1..) = index_str.parse::<u64>() {

tests/sqlparser_common.rs

@@ -1723,7 +1723,7 @@ fn parse_json_ops_without_colon() {
         (
             "->>",
             LongArrow,
-            all_dialects_except(|d| d.supports_snowflake_pipe_operator()),
+            all_dialects_except(|d| d.supports_long_arrow_pipe_operator()),
         ),
         ("#>", HashArrow, pg_and_generic()),
         ("#>>", HashLongArrow, pg_and_generic()),

tests/sqlparser_snowflake.rs

@@ -4953,13 +4953,12 @@ fn test_snowflake_pipe_operator() {
         ))
     );
 
-    // In GenericDialect, ->> remains a binary (JSON extract) operator, not a pipe
+    // GenericDialect also supports pipe syntax (it is permissive by design)
     use sqlparser::dialect::GenericDialect;
     use sqlparser::parser::Parser;
-    let stmts = Parser::parse_sql(&GenericDialect {}, "SELECT payload ->> 'name'").unwrap();
-    assert_eq!(stmts.len(), 1);
-    // In GenericDialect, SELECT 1 ->> SELECT 2 is a parse error (SELECT 2 is not an expression)
-    assert!(Parser::parse_sql(&GenericDialect {}, "SELECT 1 ->> SELECT 2").is_err());
+    Parser::parse_sql(&GenericDialect {}, "SELECT * FROM t ->> SELECT * FROM $1").unwrap();
+    // JSON ->> binary operator still works inside expressions
+    Parser::parse_sql(&GenericDialect {}, "SELECT payload ->> 'name'").unwrap();
 }
 
 #[test]