fix: gate INSERT BY NAME by dialect capability

Author: finchxxia

src/dialect/databricks.rs

@@ -95,6 +95,10 @@ impl Dialect for DatabricksDialect {
         true
     }
 
+    fn supports_insert_by_name(&self) -> bool {
+        true
+    }
+
     /// See <https://docs.databricks.com/aws/en/sql/language-manual/functions/bangsign>
     fn supports_bang_not_operator(&self) -> bool {
         true

src/dialect/generic.rs

@@ -320,4 +320,8 @@ impl Dialect for GenericDialect {
     fn supports_aliased_function_args(&self) -> bool {
         true
     }
+
+    fn supports_insert_by_name(&self) -> bool {
+        true
+    }
 }

src/dialect/mod.rs

@@ -1353,6 +1353,13 @@ pub trait Dialect: Debug + Any {
         false
     }
 
+    /// Returns true if this dialect supports `INSERT INTO ... BY NAME ...`.
+    ///
+    /// Databricks: <https://docs.databricks.com/aws/en/sql/language-manual/sql-ref-syntax-dml-insert-into>
+    fn supports_insert_by_name(&self) -> bool {
+        false
+    }
+
     /// Returns true if this dialect supports `SET` statements without an explicit
     /// assignment operator such as `=`. For example: `SET SHOWPLAN_XML ON`.
     fn supports_set_stmt_without_operator(&self) -> bool {

src/parser/mod.rs

@@ -18350,7 +18350,7 @@ impl<'a> Parser<'a> {
 
                     let partitioned = self.parse_insert_partition()?;
                     by_name = columns.is_empty()
-                        && dialect_of!(self is DatabricksDialect | GenericDialect)
+                        && self.dialect.supports_insert_by_name()
                         && self.parse_keywords(&[Keyword::BY, Keyword::NAME]);
                     // Hive allows you to specify columns after partitions as well if you want.
                     let after_columns = if dialect_of!(self is HiveDialect) {

tests/sqlparser_databricks.rs

@@ -168,37 +168,6 @@ fn test_databricks_lambdas() {
     databricks().verified_expr("transform(array(1, 2, 3), x -> x + 1)");
 }
 
-#[test]
-fn test_databricks_insert_by_name() {
-    match databricks().verified_stmt("INSERT INTO target BY NAME SELECT 1 AS a") {
-        Statement::Insert(Insert {
-            by_name,
-            columns,
-            has_table_keyword,
-            ..
-        }) => {
-            assert!(by_name);
-            assert!(columns.is_empty());
-            assert!(!has_table_keyword);
-        }
-        _ => unreachable!(),
-    }
-
-    match databricks().verified_stmt(
-        "INSERT INTO TABLE lakehouse.dwd.dwd_event_quality_sla_metric_di BY NAME WITH day AS (SELECT 1 AS event_data_id) SELECT event_data_id FROM day",
-    ) {
-        Statement::Insert(Insert {
-            by_name,
-            has_table_keyword,
-            ..
-        }) => {
-            assert!(by_name);
-            assert!(has_table_keyword);
-        }
-        _ => unreachable!(),
-    }
-}
-
 #[test]
 fn test_values_clause() {
     let values = Values {
@@ -769,3 +738,34 @@ fn parse_cte_without_as() {
         .parse_sql_statements("WITH cte (SELECT 1) SELECT * FROM cte")
         .is_err());
 }
+
+#[test]
+fn test_databricks_insert_by_name() {
+    match databricks_and_generic().verified_stmt("INSERT INTO target BY NAME SELECT 1 AS a") {
+        Statement::Insert(Insert {
+            by_name,
+            columns,
+            has_table_keyword,
+            ..
+        }) => {
+            assert!(by_name);
+            assert!(columns.is_empty());
+            assert!(!has_table_keyword);
+        }
+        _ => unreachable!(),
+    }
+
+    match databricks_and_generic().verified_stmt(
+        "INSERT INTO TABLE lakehouse.dwd.dwd_event_quality_sla_metric_di BY NAME WITH day AS (SELECT 1 AS event_data_id) SELECT event_data_id FROM day",
+    ) {
+        Statement::Insert(Insert {
+            by_name,
+            has_table_keyword,
+            ..
+        }) => {
+            assert!(by_name);
+            assert!(has_table_keyword);
+        }
+        _ => unreachable!(),
+    }
+}