You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 57f0947
Browse filesBrowse the repository at this point in the historyBrowse files
## Which issue does this PR close?
N/A — routine dependency bump; no tracking issue was filed.
## Rationale for this change
Keeps the binding current with upstream DataFusion. 55.0.0 is the latest
release, and staying close to it keeps the next bump small and makes
upstream fixes available to Java callers.
## What changes are included in this PR?
Bumps `datafusion`, `datafusion-proto`, `datafusion-spark` and
`datafusion-substrait` from 54.1.0 to 55.0.0, and `arrow` from 58 to 59
to match what DataFusion 55 resolves to. `object_store` stays on 0.13 —
DataFusion 55 still depends on `^0.13.2` — so the pin comment still
holds.
The `datafusion.version` Maven property moves in lock step, since it
selects the upstream tag the `datafusion.proto` /
`datafusion_common.proto` definitions are downloaded from — the
generated Java protobuf classes must match what `datafusion-proto`
55.0.0 decodes.
Adapting to the upstream API changes the bump requires:
- **The `datafusion.proto` schema moved** from `datafusion/proto/proto/`
to `datafusion/proto-models/proto/`, following the new
`datafusion-proto-models` crate. The `download-maven-plugin` URL is
updated, as is the recipe in
`docs/source/contributor-guide/updating-datafusion-version.md` so the
next bump does not rediscover this. Both pinned sha512 digests are
updated; each was verified to match the copy vendored in the published
`datafusion-proto-common` / `datafusion-proto-models` 55.0.0 crates,
independently of the GitHub download.
- **`ListingTableScanNode.target_partitions` was removed** upstream (now
`reserved 9`) — the partition count comes from the session config
instead. The field is dropped from the `fromProtoListingScanMatchesSql`
fixture. Note this is the *scan node's* field; the binding's own
`SessionOptionsProto.target_partitions`, which backs
`SessionContextBuilder.targetPartitions`, is unrelated and unchanged.
- **The concrete `Default*Cache` types were collapsed** into a single
generic `DefaultCache<K, V>`, so `DefaultFileStatisticsCache`,
`DefaultFilesMetadataCache` and `DefaultListFilesCache` no longer exist.
Rather than name the replacement, `cache_manager` now only sets the
cache *limits* (and the list-files TTL) and leaves the cache slots
`None`. `CacheManager::try_new` constructs the built-in cache for any
slot left `None` whose limit is non-zero — it already did so on 54 as
well — so the explicit construction was redundant on both versions and
this is behavior-preserving. It also keeps the binding off upstream's
concrete cache types entirely, which is the intent of the "configure the
built-in caches, don't swap in a custom one" contract.
- **`ExecutionPlan` gained a required `apply_expressions`.**
`JavaScanExec` is a leaf scan whose rows are produced on the Java side
and which holds no `PhysicalExpr`, so it returns
`TreeNodeRecursion::Continue` — the no-expression form upstream
documents for nodes like `EmptyExec`.
- **`datafusion_substrait::serializer::deserialize_bytes` is now
synchronous** and takes `&[u8]` rather than an owned `Vec<u8>`.
## Are these changes tested?
Covered by the existing suites — this is a dependency bump, so the value
is in the current tests continuing to pass against the new version
rather than in new assertions.
- `./mvnw test` — 349 tests, 0 failures, 0 skipped. Run with the
`substrait` Cargo feature enabled (`cargo build --features substrait`)
and with TPC-H SF1 data present, so the Substrait and data-gated tests
execute rather than skip. In particular `fromProtoListingScanMatchesSql`
— the test the `target_partitions` removal touches — asserts the
proto-built plan returns the same result as the equivalent SQL, and
passes.
- `cargo test --workspace --features substrait` — all passing.
- `cargo clippy --all-targets --workspace --features substrait -- -D
warnings` — clean.
- `cargo fmt --all` and `./mvnw spotless:apply` — clean.
- `cargo build --workspace --all-features` with `RUSTFLAGS="--cfg
tokio_unstable"`, to cover the optional `substrait` and
`runtime-metrics` features the default build does not compile.
## Are there any user-facing changes?
No API changes, and no behavior changes originating in this repo — the
cache-manager rework above is deliberately behavior-preserving. Callers
inherit whatever upstream changed between DataFusion 54.1.0 and 55.0.0.
0 commit comments