From 285158f2dc354b1e6763fb77f09febebccf1e562 Mon Sep 17 00:00:00 2001 From: Noah Date: Tue, 10 Nov 2026 09:53:03 -0500 Subject: [PATCH] fix(dev): let the Docker build scripts run when CI is unset Both scripts run under `set -u`, so `${CI}` aborted with an unbound variable error on any machine without CI set, which broke dev/integration-tests.sh locally. Default it to empty. --- dev/build-ballista-docker.sh | 2 +- dev/build-ballista-executables.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/dev/build-ballista-docker.sh b/dev/build-ballista-docker.sh index 1e4b31ca5a..e67b043190 100755 --- a/dev/build-ballista-docker.sh +++ b/dev/build-ballista-docker.sh @@ -30,7 +30,7 @@ docker build --build-arg RELEASE_FLAG="${RELEASE_FLAG}" -t "apache/datafusion-ba docker build --build-arg RELEASE_FLAG="${RELEASE_FLAG}" -t "apache/datafusion-ballista-executor:latest" -f dev/docker/ballista-executor.Dockerfile . docker build --build-arg RELEASE_FLAG="${RELEASE_FLAG}" -t "apache/datafusion-ballista-result-service:latest" -f dev/docker/ballista-result-service.Dockerfile . -if test -z "${CI}"; then +if test -z "${CI:-}"; then docker build --build-arg RELEASE_FLAG="${RELEASE_FLAG}" -t "apache/datafusion-ballista-cli:latest" -f dev/docker/ballista-cli.Dockerfile . docker build --build-arg RELEASE_FLAG="${RELEASE_FLAG}" -t "apache/datafusion-ballista-benchmarks:latest" -f dev/docker/ballista-benchmarks.Dockerfile . fi diff --git a/dev/build-ballista-executables.sh b/dev/build-ballista-executables.sh index 7fce879d30..e235ba827c 100755 --- a/dev/build-ballista-executables.sh +++ b/dev/build-ballista-executables.sh @@ -40,7 +40,7 @@ cargo build --profile "$RELEASE_FLAG" -p ballista-scheduler --bin ballista-sche cargo build --profile "$RELEASE_FLAG" -p ballista-executor --bin ballista-executor cargo build --profile "$RELEASE_FLAG" -p ballista-result-service --bin ballista-result-service -if test -z "${CI}"; then +if test -z "${CI:-}"; then cargo build --profile "$RELEASE_FLAG" -p ballista-cli --bin ballista-cli cargo build --profile "$RELEASE_FLAG" -p ballista-benchmarks --bin tpch fi \ No newline at end of file