From 0b301550c9047a6bee23aee58d6f0bfbeb131aa9 Mon Sep 17 00:00:00 2001 From: "hunghh.dev" Date: Thu, 30 Jul 2026 20:43:36 +0700 Subject: [PATCH 1/2] Fix StringUtils.trimAsciiControl Javadoc --- .../java/org/apache/commons/lang3/StringUtils.java | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java b/src/main/java/org/apache/commons/lang3/StringUtils.java index 5b8b03d7283..231a74ae991 100644 --- a/src/main/java/org/apache/commons/lang3/StringUtils.java +++ b/src/main/java/org/apache/commons/lang3/StringUtils.java @@ -8845,18 +8845,19 @@ public static String trim(final String str) { } /** - * Removes control characters (char <= 31) from both ends of this String, handling {@code null} by returning {@code null}. + * Removes {@link CharUtils#isAsciiControl(char) ASCII control characters} (char <= 31 or char == 127) from both ends of this String, handling + * {@code null} by returning {@code null}. * *

* To trim your choice of characters, use the {@link #strip(String, String)} methods. *

* *
{@code
-     * StringUtils.trim(null)          = null
-     * StringUtils.trim("")            = ""
-     * StringUtils.trim("abc\u0000")   = "abc"
-     * StringUtils.trim("abc")         = "abc"
-     * StringUtils.trim(" abc ")       = " abc "
+     * StringUtils.trimAsciiControl(null)          = null
+     * StringUtils.trimAsciiControl("")            = ""
+     * StringUtils.trimAsciiControl("abc\u0000")   = "abc"
+     * StringUtils.trimAsciiControl("abc")         = "abc"
+     * StringUtils.trimAsciiControl(" abc ")       = " abc "
      * }
* * @param str The String to be trimmed, may be null. From 36e89969aead828860bfe47792fa3365cb45196c Mon Sep 17 00:00:00 2001 From: "hunghh.dev" Date: Thu, 30 Jul 2026 20:56:24 +0700 Subject: [PATCH 2/2] Fix StringUtils.abbreviate Javadoc example for a single-character marker --- src/main/java/org/apache/commons/lang3/StringUtils.java | 2 +- .../org/apache/commons/lang3/StringUtilsAbbreviateTest.java | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/apache/commons/lang3/StringUtils.java b/src/main/java/org/apache/commons/lang3/StringUtils.java index 231a74ae991..7d40648c0be 100644 --- a/src/main/java/org/apache/commons/lang3/StringUtils.java +++ b/src/main/java/org/apache/commons/lang3/StringUtils.java @@ -335,7 +335,7 @@ public static String abbreviate(final String str, final String abbrevMarker, fin * StringUtils.abbreviate("abcdefghijklmno", ",", 2, 10) = "abcdefghi," * StringUtils.abbreviate("abcdefghijklmno", "::", 4, 10) = "::efghij::" * StringUtils.abbreviate("abcdefghijklmno", "...", 6, 10) = "...ghij..." - * StringUtils.abbreviate("abcdefghijklmno", "…", 6, 10) = "…ghij…" + * StringUtils.abbreviate("abcdefghijklmno", "…", 6, 10) = "…ghijklmno" * StringUtils.abbreviate("abcdefghijklmno", "*", 9, 10) = "*ghijklmno" * StringUtils.abbreviate("abcdefghijklmno", "'", 10, 10) = "'ghijklmno" * StringUtils.abbreviate("abcdefghijklmno", "!", 12, 10) = "!ghijklmno" diff --git a/src/test/java/org/apache/commons/lang3/StringUtilsAbbreviateTest.java b/src/test/java/org/apache/commons/lang3/StringUtilsAbbreviateTest.java index 55d2f0fa284..9b37cc808da 100644 --- a/src/test/java/org/apache/commons/lang3/StringUtilsAbbreviateTest.java +++ b/src/test/java/org/apache/commons/lang3/StringUtilsAbbreviateTest.java @@ -154,6 +154,7 @@ void testAbbreviate_StringStringIntInt() { assertAbbreviateWithAbbrevMarkerAndOffset("abcdef____", "____", 5, 10); assertAbbreviateWithAbbrevMarkerAndOffset("==fghijk==", "==", 5, 10); assertAbbreviateWithAbbrevMarkerAndOffset("___ghij___", "___", 6, 10); + assertAbbreviateWithAbbrevMarkerAndOffset("…ghijklmno", "…", 6, 10); assertAbbreviateWithAbbrevMarkerAndOffset("/ghijklmno", "/", 7, 10); assertAbbreviateWithAbbrevMarkerAndOffset("/ghijklmno", "/", 8, 10); assertAbbreviateWithAbbrevMarkerAndOffset("/ghijklmno", "/", 9, 10);