From a1c24035b79a0969c7ac0321d2c29ff5ccc1d6c5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20Cumplido?= Date: Mon, 16 Nov 2026 11:09:18 +0100 Subject: [PATCH 1/2] GH-55630: [C++][CI] Append expected prefix on ResolveSimdjsonResult error --- cpp/src/arrow/json/parser.cc | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/cpp/src/arrow/json/parser.cc b/cpp/src/arrow/json/parser.cc index 08d83f0c67fb..bc5543d6f30e 100644 --- a/cpp/src/arrow/json/parser.cc +++ b/cpp/src/arrow/json/parser.cc @@ -945,8 +945,9 @@ class ParseImpl : public BlockParser { RETURN_NOT_OK(struct_builder->Append()); ARROW_ASSIGN_OR_RAISE( - auto object, arrow::internal::ResolveSimdjsonResult(value.get_object(), - "Failed to get JSON object")); + auto object, + arrow::internal::ResolveSimdjsonResult( + value.get_object(), "JSON parse error: Failed to get JSON object")); for (auto field_result : object) { ARROW_ASSIGN_OR_RAISE(auto field, @@ -954,9 +955,10 @@ class ParseImpl : public BlockParser { std::move(field_result), "JSON parse error: Failed to iterate JSON object")); - ARROW_ASSIGN_OR_RAISE(auto key, - arrow::internal::ResolveSimdjsonResult( - field.unescaped_key(), "Failed to get JSON object key")); + ARROW_ASSIGN_OR_RAISE( + auto key, + arrow::internal::ResolveSimdjsonResult( + field.unescaped_key(), "JSON parse error: Failed to get JSON object key")); RETURN_NOT_OK(ParseObjectField(key, field.value())); } From 14a5f461208f80b6ba400c582ab04d50fb48d2bf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ra=C3=BAl=20Cumplido?= Date: Mon, 16 Nov 2026 11:47:02 +0100 Subject: [PATCH 2/2] Try to zero the padding to make it consistent between versions --- cpp/src/arrow/json/chunker.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/cpp/src/arrow/json/chunker.cc b/cpp/src/arrow/json/chunker.cc index c1397ba876cc..a5528c3df96d 100644 --- a/cpp/src/arrow/json/chunker.cc +++ b/cpp/src/arrow/json/chunker.cc @@ -101,6 +101,10 @@ class ParsingBoundaryFinder : public BoundaryFinder { auto data = buffer_->mutable_data(); std::memcpy(data, partial.data(), partial.size()); std::memcpy(data + partial.size(), block.data(), block.size()); + // simdjson >= 5.2.0 may look at bytes past the input when it delimits documents + // (simdjson/simdjson#3031), so stale padding contents could change where + // documents are cut. Zero the padding to make this deterministic. + std::memset(data + data_size, 0, simdjson::SIMDJSON_PADDING); auto view = simdjson::padded_string_view(data, /*len=*/data_size, /*capacity=*/buffer_->capacity()); DCHECK(view.has_sufficient_padding());