Repository navigation
Commit 9b86032
committed
GH-238: Stop TestNettyAllocator wrapping Netty's empty buffer in a 1024-byte ArrowBuf
TestNettyAllocator.testMemoryUsage wrapped a 1024-byte NO_OP ArrowBuf around
the memory address of PooledByteBufAllocatorL's empty buffer, whose native
allocation is only a few bytes. The test only reads the address today, but
any read or write through that buffer would run past the end of the native
allocation, as in TestEmptyArrowBuf (#1426).
The buffer isn't needed: the memory usage log the test waits for comes from
the status thread that the PooledByteBufAllocatorL constructor starts when
TRACE logging is enabled. Construct the allocator directly instead.
Closes #238.1 parent 221124a commit 9b86032
1 file changed
Lines changed: 2 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
29 | | - | |
30 | 28 | | |
31 | 29 | | |
32 | 30 | | |
| |||
43 | 41 | | |
44 | 42 | | |
45 | 43 | | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
| 44 | + | |
| 45 | + | |
54 | 46 | | |
55 | 47 | | |
56 | 48 | | |
| |||
0 commit comments