Skip to content

Commit f4baace

Browse files
committed
refactor(google-maps): move types reference in maps package
We need at least one `<reference types="google.maps" preserve="true" />` present in the Google Maps package in order to ensure that the .d.ts we publish has a reference to the types, however internally they need to be stripped. These changes remove the reference that was randomly places in the clusterer types and will update the internal setup to drop the comment.
1 parent 0bb7b18 commit f4baace

4 files changed

Lines changed: 4 additions & 6 deletions

File tree

MODULE.bazel.lock

Lines changed: 0 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/google-maps/deprecated-map-marker-clusterer/deprecated-marker-clusterer-types.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
* found in the LICENSE file at https://angular.dev/license
77
*/
88

9-
/// <reference types="google.maps" preserve="true" />
10-
119
/**
1210
* Class for clustering markers on a Google Map.
1311
*

src/google-maps/index.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,8 @@
66
* found in the LICENSE file at https://angular.dev/license
77
*/
88

9+
// We need this to ensure that the type reference is present in the generated .d.ts
10+
// that we publish to npm. Internally this is removed during import.
11+
/// <reference types="google.maps" preserve="true" />
12+
913
export * from './public-api';

src/google-maps/map-marker-clusterer/map-marker-clusterer-types.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
* found in the LICENSE file at https://angular.dev/license
77
*/
88

9-
/// <reference types="google.maps" preserve="true" />
10-
119
import {Marker} from '../marker-utilities';
1210

1311
// This file duplicates the necessary types from the `@googlemaps/markerclusterer`

0 commit comments

Comments
 (0)