fix(@angular/cli): fallback to deprecated versions when resolving ranges if no non-deprecated version is found

When using ng update to resolve package version ranges on the command line, we previously skipped deprecated package versions entirely during pre-validation. In cases where all versions satisfying the range are deprecated, this resulted in update failure. Now, we attempt to find a satisfying version from non-deprecated versions first, and fallback to deprecated versions if none are found. This aligns the CLI pre-validation with the update schematic resolution logic.

Author: alan-agius4

packages/angular/cli/src/commands/update/cli.ts

@@ -682,29 +682,30 @@ export default class UpdateCommandModule extends CommandModule<UpdateCommandArgs
         case 'version':
           manifest = metadata.versions[requestIdentifier.fetchSpec];
           break;
-        case 'range':
-          for (const potentialManifest of Object.values(metadata.versions)) {
-            // Ignore deprecated package versions
-            if (potentialManifest.deprecated) {
-              continue;
-            }
-            // Only consider versions that are within the range
-            if (
-              !semver.satisfies(potentialManifest.version, requestIdentifier.fetchSpec, {
-                loose: true,
-              })
-            ) {
-              continue;
-            }
-            // Update the used manifest if current potential is newer than existing or there is not one yet
-            if (
-              !manifest ||
-              semver.gt(potentialManifest.version, manifest.version, { loose: true })
-            ) {
-              manifest = potentialManifest;
+        case 'range': {
+          const potentialManifests = Object.values(metadata.versions).filter((potentialManifest) =>
+            semver.satisfies(potentialManifest.version, requestIdentifier.fetchSpec, {
+              loose: true,
+            }),
+          );
+
+          const nonDeprecated = potentialManifests.filter((m) => !m.deprecated);
+          const deprecated = potentialManifests.filter((m) => !!m.deprecated);
+
+          const selectLatest = (manifests: PackageManifest[]) => {
+            let max: PackageManifest | undefined;
+            for (const m of manifests) {
+              if (!max || semver.gt(m.version, max.version, { loose: true })) {
+                max = m;
+              }
             }
-          }
+
+            return max;
+          };
+
+          manifest = selectLatest(nonDeprecated) ?? selectLatest(deprecated);
           break;
+        }
       }
 
       if (!manifest) {