fix(@angular/cli): expand shell metacharacter rejection and disable requiresQuoting

Author: Tednoob17

packages/angular/cli/src/commands/add/cli.ts

@@ -32,7 +32,7 @@ import { VERSION } from '../../utilities/version';
 
 class CommandError extends Error {}
 
-export const SHELL_METACHARACTERS = /[&|;$`()]/;
+export const SHELL_METACHARACTERS = /[&|;$`()<>'"\n\r]/;
 
 export function validateRegistry(registry: string): void {
   if (!URL.canParse(registry)) {

packages/angular/cli/src/commands/add/registry-validation.spec.ts

@@ -15,9 +15,15 @@ describe('registry validation', () => {
       expect(SHELL_METACHARACTERS.test('|')).toBe(true);
       expect(SHELL_METACHARACTERS.test(';')).toBe(true);
       expect(SHELL_METACHARACTERS.test('$')).toBe(true);
-      expect(SHELL_METACHARACTERS.test('`')).toBe(true);
+      expect(SHELL_METACHARACTERS.test(String.fromCharCode(96))).toBe(true);
       expect(SHELL_METACHARACTERS.test('(')).toBe(true);
       expect(SHELL_METACHARACTERS.test(')')).toBe(true);
+      expect(SHELL_METACHARACTERS.test('<')).toBe(true);
+      expect(SHELL_METACHARACTERS.test('>')).toBe(true);
+      expect(SHELL_METACHARACTERS.test('"')).toBe(true);
+      expect(SHELL_METACHARACTERS.test("'")).toBe(true);
+      expect(SHELL_METACHARACTERS.test('\n')).toBe(true);
+      expect(SHELL_METACHARACTERS.test('\r')).toBe(true);
     });
 
     it('should not match safe URL characters', () => {
@@ -47,6 +53,9 @@ describe('registry validation', () => {
       expect(() => validateRegistry('https://example.com(cmd)')).toThrow(
         'Option --registry contains invalid characters.',
       );
+      expect(() => validateRegistry('https://example.com?q=">whoami')).toThrow(
+        'Option --registry contains invalid characters.',
+      );
     });
 
     it('should accept valid URLs', () => {

packages/angular/cli/src/package-managers/host.ts

@@ -107,7 +107,6 @@ export interface Host {
  */
 export const NodeJS_HOST: Host = {
   stat,
-  requiresQuoting: platform() === 'win32',
   mkdir,
   readFile: (path: string) => readFile(path, { encoding: 'utf8' }),
   copyFile: (src, dest) => copyFile(src, dest, constants.COPYFILE_FICLONE),