test(@angular/cli): remove unscoped authentication test cases from registry tests

Author: clydin

tests/legacy-cli/e2e/tests/commands/add/secure-registry.ts

@@ -1,39 +1,23 @@
 import { expectFileNotToExist, expectFileToExist } from '../../../utils/fs';
-import { getActivePackageManager, installWorkspacePackages } from '../../../utils/packages';
+import { installWorkspacePackages } from '../../../utils/packages';
 import { git, ng } from '../../../utils/process';
 import { createNpmConfigForAuthentication } from '../../../utils/registry';
 import { expectToFail } from '../../../utils/utils';
 
 export default async function () {
   // The environment variable has priority over the .npmrc
   delete process.env['NPM_CONFIG_REGISTRY'];
-  const isNpm = getActivePackageManager() === 'npm';
 
   const command = ['add', '@angular/pwa', '--skip-confirmation'];
-  await expectFileNotToExist('public/manifest.webmanifest');
 
-  // Works with unscoped registry authentication details
-  if (!isNpm) {
-    // NPM no longer support unscoped.
-    await createNpmConfigForAuthentication(false);
-    await ng(...command);
-    await expectFileToExist('public/manifest.webmanifest');
-    await git('clean', '-dxf');
-  }
   // Works with scoped registry authentication details
   await expectFileNotToExist('public/manifest.webmanifest');
 
-  await createNpmConfigForAuthentication(true);
+  await createNpmConfigForAuthentication();
   await ng(...command);
   await expectFileToExist('public/manifest.webmanifest');
 
   // Invalid authentication token
-  if (isNpm) {
-    // NPM no longer support unscoped.
-    await createNpmConfigForAuthentication(false, true);
-    await expectToFail(() => ng(...command));
-  }
-
   await createNpmConfigForAuthentication(true, true);
   await expectToFail(() => ng(...command));
 

tests/legacy-cli/e2e/tests/update/update-secure-registry.ts

@@ -16,22 +16,13 @@ export default async function () {
   }
 
   // Valid authentication token
-  await createNpmConfigForAuthentication(false);
-  const { stdout: stdout1 } = await ng('update', ...extraArgs);
-  if (!stdout1.includes(worksMessage)) {
-    throw new Error(`Expected stdout to contain "${worksMessage}"`);
-  }
-
-  await createNpmConfigForAuthentication(true);
+  await createNpmConfigForAuthentication();
   const { stdout: stdout2 } = await ng('update', ...extraArgs);
   if (!stdout2.includes(worksMessage)) {
     throw new Error(`Expected stdout to contain "${worksMessage}"`);
   }
 
   // Invalid authentication token
-  await createNpmConfigForAuthentication(false, true);
-  await expectToFail(() => ng('update', ...extraArgs));
-
   await createNpmConfigForAuthentication(true, true);
   await expectToFail(() => ng('update', ...extraArgs));
 

tests/legacy-cli/e2e/utils/registry.ts

@@ -58,7 +58,7 @@ export function createNpmConfigForAuthentication(
    * _auth="dGVzdGluZzpzM2NyZXQ="`
    * ```
    */
-  scopedAuthentication: boolean,
+  scopedAuthentication = true,
   /** When true, an incorrect token is used. Use this to validate authentication failures. */
   invalidToken = false,
 ): Promise<void> {