-
Notifications
You must be signed in to change notification settings - Fork 683
Edit button displayed for non-editable resources (PDFs and images) in Publish dialog #836
Description
In the OpenCMS publish dialog, the edit button (pencil icon) is being displayed for binary resources such as PDF files, even though these resources do not have a valid editor configured in the system. When clicking this button, an exception is thrown indicating that no valid editor can be found for the file, confirming that the resource is not editable through the Workplace. This behavior is inconsistent, as editing is not allowed for these documents either in the galleries or directly within the Workplace, even when the user belongs to the “Workplace Users” group and has the appropriate permissions. Additionally, this issue also occurs in some cases with image files, where the edit option is shown despite no applicable editor being available. This suggests that the publish dialog is not properly validating whether a resource has an associated editor before rendering the edit button, indicating a display or validation issue within that view.
Steps to Reproduce
1. Upload a PDF file to OpenCMS (for example under /galleries/Documents/).
2. Ensure the file is added to a publish project.
3. Open the Publish dialog (Publish tool).
4. Locate the uploaded PDF in the list of resources to be published.
5. Verify that the edit icon (pencil) is displayed next to the resource.
6. Click the edit icon.
Scenario A – User with Workplace Users role:
The system attempts to open the editor and throws an exception indicating that no valid editor can be found for the file.

Scenario B – User without sufficient Workplace permissions:
The edit option may still be displayed in the publish dialog, but editing is not actually supported for the resource type, leading to inconsistent behavior.
