StringCondition.isValidUUID potentially too restrictive

[yohanan]

the following String works with UUID.fromString() but fails StringCondition.isValidUUID(): "FFFF0000-FFFF-0000-FFFF-9FAA33C4C754".

[trevjonez]

The culprit is going to be the regex here

It is being strict on the version and variant bits and I wonder if being more relaxed here should be frowned on. Question being more so who is creating UUID's in your system that doesn't pass the regex? At least in our use case we have not seen issues with this yet. Seems that this is not really an issue here but more a symptom of issues else where. to which end the library is doing its job well?

[yohanan]

i'm comfortable leaving the regex as-is. i was more curious what those bits were: i don't know the intricacies of RFC4122. thanks for clarifying.

i, however, was a bit surprised that Java's UUID.fromString accepted something that didn't pass the regex.

[trevjonez]

so something that we saw a great deal of when we wrote the isValidUUID method was method signatures that looked something like Thing getThingById(@NonNull @Size(36) String thingId) so you would immediately call isValidUUID on thingId param. At a later point we did some work to migrate everything to the stronger type UUID so that the methods became Thing getThingById(@NonNull UUID thingId) at which point it would be a call to isNotNull. Then finally you can take this to an extreme and begin converting to kotlin and not use DBC for simple null checks since you get it as a part of the language which is much more appropriate all together. fun getThingById(thingId: UUID): Thing any other checks needed can be done with the functions provided in kotlin.util.Preconditions.