Skip to content

Export CSV exports also Array prototype #47

Description

@vladrusu04

If you add any methods on Array/Object prototype then the for in loop from getBody() method will try to export it.
https://github.com/alhazmy13/angular-csv-ext/blob/master/Angular-csv.ts#L136

As a fix I would suggest using the hasOwnProperty method to avoid iterate over inherited properties, or maybe use Object.keys() and iterate over them to fully avoid for in loop

How to reproduce:

Array.prototype.myFunct = function () { return this; }

const data = [1, 2, 3];
new AngularCsv(data, 'My Report');

// the output will be a CSV file with
// 1, 2, 3, function () { return this; }

For moment, as a hack workaround I override the toString() method for prototype functions:

Array.prototype.myFunct = myFunct;

function myFunct() { return this; }
myFunct.toString = () => '';

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions