Skip to content

ecrecover implementation issue #81

@vaishnavipanchal23

Description

@vaishnavipanchal23

Web3 version: aion-web3 v1.2.6-beta.0

Implementation issue of recover function https://github.com/aionnetwork/aion_web3/blob/v1.1/packages/web3-eth-accounts/src/index.js#L316

Current implementation:
Returns the address by retrieving the public key from first 32 bytes of the signature. This ignores the signature verification completely.

Expected implementation:
Return the address of the signer only if the signature is verified for the given message.

Note: Also, this function name should be edverify.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions