Repository navigation
Commit 5e1225b
Mark Pollack
Move the unknown-field policy from the schema records to the mapper
Every schema record carried @JsonIgnoreProperties(ignoreUnknown = true).
That made the SDK tolerate fields it does not know, which is deliberate:
the specification adds fields between releases and an agent newer than
this SDK must keep working. But a class-level annotation wins over any
mapper configuration, so a consumer who passed a strict ObjectMapper to
JacksonAcpJsonMapper got no strictness at all (#10). Removing the
annotations alone would have flipped the default the other way, because
the default supplier used a bare new ObjectMapper(), whose Jackson
default is to fail on unknown properties.
The annotations are gone and the policy lives in the mapper. The default
supplier now uses JacksonAcpJsonMapper.defaultObjectMapper(), which
disables FAIL_ON_UNKNOWN_PROPERTIES and logs each ignored property at
DEBUG so spec drift can be observed without making the wire strict. A
consumer who supplies a strict mapper gets strict behaviour; one who
supplies a bare ObjectMapper now gets Jackson's default, which the
changelog calls out. Unknown fields are not routed into _meta.
Reported by @KallivdH.1 parent 85fb3c5 commit 5e1225b
5 files changed
Lines changed: 136 additions & 126 deletions
File tree
- acp-core/src
- main/java/com/agentclientprotocol/sdk
- json
- spec
- test/java/com/agentclientprotocol/sdk/json
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
39 | 39 | | |
40 | 40 | | |
41 | 41 | | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
42 | 56 | | |
43 | 57 | | |
44 | 58 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
10 | 14 | | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
11 | 19 | | |
12 | 20 | | |
13 | 21 | | |
| |||
17 | 25 | | |
18 | 26 | | |
19 | 27 | | |
| 28 | + | |
| 29 | + | |
20 | 30 | | |
21 | 31 | | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
22 | 74 | | |
23 | 75 | | |
24 | 76 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
0 commit comments