Skip to content

EngineFixes needs to be compiled against a newer LibCommonSSE #70

@ashemedai

Description

@ashemedai

Currently EngineFixes has a problem with non-Steam builds.

GOG's build expects the Skyrim INI and save files to be located at Documents\My Games\Skyrim Special Edition GOG and not Documents\My Games\Skyrim Special Edition.

The current code has some assumptions:

std::filesystem::path path = mydocs.get();
path /= "My Games"sv;
path /= "Skyrim Special Edition"sv;
auto sLocalSavePath = RE::GetINISetting("sLocalSavePath:General");

With GOG's Skyrim this causes the wrong location to be probed for save files. The EngineFixes.log file that gets placed in Documents\My Games\Skyrim.INI\SKSE states F:\skyrim-dev\ef\EngineFixesSkyrim64\src\utils.cpp(27): [error] Path "C:\Users\asmodai\Documents\My Games\Skyrim Special Edition\Saves\" does not exist.

Similary, the logger implementation is broken. With GOG's Skyrim this causes Documents\My Games\Skyrim.INI to be created due to the logging implementation using a wrong ID (380738), which seems to fetch the string Skyrim.INI.

PR #69 has good ideas. The LibCommonSSE used is not up-to-date. A replacement such as powerof3's LibCommonSSE would be recommended. There's also alandtse's with VR support or the NG version, both of which solve it in a different way if you check Logger.cpp.

Another avenue is pulling in the library and patching it locally, as done here. I haven't verified the ID though.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions