feat(breaking): run add-vscode-config generator on app init (retooled local debugging) (#801)

* fix: ACNA-2785 - run add-vscode-config generator on app init

* updated unit tests

---------

Co-authored-by: Jesse MacFadyen <purplecabbage@gmail.com>

Author: shazron

package.json

@@ -15,7 +15,7 @@
     "@adobe/aio-lib-runtime": "^7.1.0",
     "@adobe/aio-lib-templates": "^3",
     "@adobe/aio-lib-web": "^7",
-    "@adobe/generator-aio-app": "^7",
+    "@adobe/generator-aio-app": "^8",
     "@adobe/generator-app-common-lib": "^2",
     "@adobe/inquirer-table-checkbox": "^2",
     "@oclif/core": "^2.11.6",

src/commands/app/init.js

@@ -75,7 +75,7 @@ class InitCommand extends TemplatesCommand {
 
   getInitialGenerators (flags) {
     // TODO read from config to override
-    const initialGenerators = ['base-app', 'add-ci']
+    const initialGenerators = ['base-app', 'add-ci', 'add-vscode-config']
 
     if (flags['standalone-app']) {
       initialGenerators.push('application')

test/commands/app/init.test.js

@@ -316,7 +316,7 @@ describe('--no-login', () => {
 
     expect(command.config.runHook).not.toHaveBeenCalled()
     expect(command.installTemplates).toHaveBeenCalledWith(installOptions)
-    expect(command.runCodeGenerators).toHaveBeenCalledWith(['base-app', 'add-ci', 'application'], false, 'cwd', 'basic')
+    expect(command.runCodeGenerators).toHaveBeenCalledWith(['base-app', 'add-ci', 'add-vscode-config', 'application'], false, 'cwd', 'basic')
     expect(LibConsoleCLI.init).not.toHaveBeenCalled()
     expect(importHelperLib.importConfigJson).not.toHaveBeenCalled()
   })
@@ -469,7 +469,7 @@ describe('--no-login', () => {
     await command.run()
 
     expect(command.installTemplates).toHaveBeenCalledWith(installOptions)
-    expect(command.runCodeGenerators).toHaveBeenCalledWith(['base-app', 'add-ci', 'application'], true, 'cwd', 'none')
+    expect(command.runCodeGenerators).toHaveBeenCalledWith(['base-app', 'add-ci', 'add-vscode-config', 'application'], true, 'cwd', 'none')
     expect(LibConsoleCLI.init).not.toHaveBeenCalled()
     expect(importHelperLib.importConfigJson).not.toHaveBeenCalled()
   })
@@ -487,7 +487,7 @@ describe('--no-login', () => {
     await command.run()
 
     expect(command.installTemplates).toHaveBeenCalledWith(installOptions)
-    expect(command.runCodeGenerators).toHaveBeenCalledWith(['base-app', 'add-ci', 'application'], true, 'cwd', 'adobe-recommended')
+    expect(command.runCodeGenerators).toHaveBeenCalledWith(['base-app', 'add-ci', 'add-vscode-config', 'application'], true, 'cwd', 'adobe-recommended')
     expect(LibConsoleCLI.init).not.toHaveBeenCalled()
     expect(importHelperLib.importConfigJson).not.toHaveBeenCalled()
   })