Silent errors should return false, not the defective Json

[geri777]

Thank you for this great and helpful library.

As described in the manual, the Fixer returns the original string if it can't be fixed.

(new Fixer)->silent()->fix('invalid');
// 'invalid'

This is maybe not the best way, because it is not possible to detect, if an error occured or not.
If any error happens silently, the function should return false.

[adhocore]

Sorry for late. Thanks for raising issue. I think it makes sense. Would be great if you could do quick PR :)
Just my thought, I think return false should not be default or at least should be configurable to achieve current working. Perhaps we add falseOnFailure() method to achieve your proposal? 😎

[ignacio-dev]

Was this ever fixed?

[adhocore]

no it seems

[adhocore]

i think thats by design, silent mode is for suppressing exception.