OsSocketAddr is unsound in upcoming rustc release

[Noah-Kennedy]

This crate assumes that rust's SocketAddr types are implemented with the C layout, which is not guaranteed. It has generally happened to be true in the past, but this is no longer going to be true. I would suggest modifying the conversion trait implementations to get around this.

[a-ba]

thanks for the report

[Noah-Kennedy]

Thanks for the response! I would also strongly recommend filing a rustsec advisory for the unpatched versions of this crate and potentially yanking unpatched versions as well, once this fix is released.

[a-ba]

that was already in my todo list ;-)

[Noah-Kennedy]

Awesome!