YurMil/Shell-Rolling-Master computes developed lengths from a normative basis (neutral-axis/K-factor treatment, EN and ASME presets) and has no tests at all — the only calculator in the catalog without them.
This is the engine behind the worked example published in #118, where the numbers were verified by running calculateShell manually. Those same cases should be committed as tests.
Suggested starting coverage:
- cylinder developed length from OD and from ID (the ID/OD distinction is worth a test of its own — it is a +94 mm error at DN 2000)
- K-factor effect at the range limits
- cone and eccentric-cone modes
- validation guards: K outside 0..1, gap larger than the circumference, non-positive dimensions
Acceptance criteria:
Found while writing the QA strategy page (#105).
This repo is using Opire - what does it mean? 👇
💵 Everyone can add rewards for this issue commenting /reward 100 (replace 100 with the amount).
🕵️♂️ If someone starts working on this issue to earn the rewards, they can comment /try to let everyone know!
🙌 And when they open the PR, they can comment /claim #153 either in the PR description or in a PR's comment.
🪙 Also, everyone can tip any user commenting /tip 20 @YurMil (replace 20 with the amount, and @YurMil with the user to tip).
📖 If you want to learn more, check out our documentation.
YurMil/Shell-Rolling-Mastercomputes developed lengths from a normative basis (neutral-axis/K-factor treatment, EN and ASME presets) and has no tests at all — the only calculator in the catalog without them.This is the engine behind the worked example published in #118, where the numbers were verified by running
calculateShellmanually. Those same cases should be committed as tests.Suggested starting coverage:
Acceptance criteria:
Found while writing the QA strategy page (#105).
This repo is using Opire - what does it mean? 👇
💵 Everyone can add rewards for this issue commenting
/reward 100(replace100with the amount).🕵️♂️ If someone starts working on this issue to earn the rewards, they can comment
/tryto let everyone know!🙌 And when they open the PR, they can comment
/claim #153either in the PR description or in a PR's comment.🪙 Also, everyone can tip any user commenting
/tip 20 @YurMil(replace20with the amount, and@YurMilwith the user to tip).📖 If you want to learn more, check out our documentation.