diff --git a/.github/workflows/publish-images.yml b/.github/workflows/publish-images.yml index 5a72235a..7cde800a 100644 --- a/.github/workflows/publish-images.yml +++ b/.github/workflows/publish-images.yml @@ -115,6 +115,8 @@ jobs: provenance: false - name: Summarize published tags + env: + PUBLISHED_TAGS: ${{ steps.meta.outputs.tags }} run: | { echo "### Published Images" @@ -123,9 +125,7 @@ jobs: echo "Commit: ${{ steps.meta.outputs.COMMIT_SHA }}" echo "" echo "Tags:" - while IFS= read -r tag; do + printf '%s\n' "$PUBLISHED_TAGS" | while IFS= read -r tag; do echo "- \`${tag}\`" - done <<'EOF' -${{ steps.meta.outputs.tags }} -EOF + done } >> "$GITHUB_STEP_SUMMARY" \ No newline at end of file diff --git a/web/src/pages/deploy/CreateDeploymentPage.test.tsx b/web/src/pages/deploy/CreateDeploymentPage.test.tsx index 49b74536..646b2b11 100644 --- a/web/src/pages/deploy/CreateDeploymentPage.test.tsx +++ b/web/src/pages/deploy/CreateDeploymentPage.test.tsx @@ -395,9 +395,9 @@ describe('CreateDeploymentPage', () => { app_required_disk_gib: '', }, }) - expect( - screen.queryByText('Create blocked by preflight: Preflight completed with warnings') - ).not.toBeInTheDocument() + expect(screen.getByRole('alert')).not.toHaveTextContent( + 'Create blocked by preflight: Preflight completed with warnings' + ) }) it('blocks create when estimated app disk exceeds available disk', async () => { @@ -484,9 +484,9 @@ describe('CreateDeploymentPage', () => { '/api/actions/install/manual-compose', expect.anything() ) - expect( - screen.getByText('Create blocked by preflight: Preflight found blocking issues') - ).toBeInTheDocument() + expect(await screen.findByRole('alert')).toHaveTextContent( + 'Create blocked by preflight: Preflight found blocking issues' + ) expect( screen.getByText( 'Application estimated disk requirement (2147483648 bytes) exceeds available disk space (1073741824 bytes)'