From 26bb2ac0b4b08cfd6008e53dbe2e2ff24a37805d Mon Sep 17 00:00:00 2001 From: Sam Clegg Date: Sun, 26 Oct 2025 13:52:16 -0700 Subject: [PATCH] Bump min cmake version It turns out the that feature I used in #7994 requires 3.24. We could revert or we could bump out min cmake version. --- CMakeLists.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 08359d809c7..2910ec5ff4a 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1,6 +1,7 @@ -# Version set according the the cmake versions available in Ubuntu/Bionic: -# https://packages.ubuntu.com/focal/cmake -cmake_minimum_required(VERSION 3.16.3) +# Version set according the the cmake versions available in Ubuntu/Noble LTS: +# https://launchpad.net/ubuntu/+source/cmake/3.28.3-1build7 +# In particualr with use LINK_LIBRARY:WHOLE_ARCHIVE which requires 3.24. +cmake_minimum_required(VERSION 3.28) # Needed for C++17 (std::variant) # TODO(https://github.com/WebAssembly/binaryen/issues/4299): We need