-
Notifications
You must be signed in to change notification settings - Fork 0
Peer to Peer code review. #8
Description
Wonderful Job !!!
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight
✅ You used the correct Github flow
✅ Descriptive pull request message
✅ local storage well used
Required Changes ♻️
Check the comments under the review
Optional suggestions
_Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Changes to be made:
Try to make your code DRY, there are several codes that are repeating within your Javascript files.
Try to remove the code that you haven't used, I saw some functions that were declared but weren't used. By doing this you will follow the best practices in Javascript.
Regards,