chore: address AI code review comments

- Pass exit codes during code generation by removing masked error trap.
- Fix README.md instructions for navigating before setup.
- Add explicit utf-8 encodings when opening JSON files.

Author: cusell-google

README.md

@@ -34,12 +34,12 @@ Python.
 For now, you can install the SDK using the following commands:
 
 ```bash
-# Create a directory for the SDK
-mkdir sdk
-
 # Clone the repository
 git clone https://github.com/Universal-Commerce-Protocol/python-sdk.git
 
+# Navigate to the directory
+cd python-sdk
+
 # Install dependencies
 uv sync
 ```

generate_models.sh

@@ -75,7 +75,7 @@ uv run \
 
 echo "Formatting generated models..."
 uv run ruff format
-uv run ruff check --fix "$OUTPUT_DIR" 2>&1 | grep -E "^(All checks passed|Fixed|Found)" || echo "Formatting complete"
+uv run ruff check --fix "$OUTPUT_DIR"
 
 
 echo "Done. Models generated in $OUTPUT_DIR"

preprocess_schemas.py

@@ -22,13 +22,13 @@
 
 def load_json(path):
     """Loads JSON data from a file."""
-    with open(path) as f:
+    with open(path, "r", encoding="utf-8") as f:
         return json.load(f)
 
 
 def save_json(data, path):
     """Saves data to a JSON file with standard indentation."""
-    with open(path, "w") as f:
+    with open(path, "w", encoding="utf-8") as f:
         json.dump(data, f, indent=2)