From b0289632930e69c3aefe1526079b623ec396a028 Mon Sep 17 00:00:00 2001 From: Joe Jones Date: Wed, 5 Aug 2026 11:00:01 -0700 Subject: [PATCH 1/6] Refactor labeler configuration for clarity and structure --- .github/labeler.yml | 268 ++++++++++++++++++++++---------------------- 1 file changed, 131 insertions(+), 137 deletions(-) diff --git a/.github/labeler.yml b/.github/labeler.yml index f8f9bcf82..7f33be833 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -1,137 +1,131 @@ -# Configuration for Auto Labeler during pull request -# -# See https://github.com/actions/labeler for file format -# and https://github.com/google/flatbuffers/labels for a list of valid labels -# -# See .github/workflows/label.yml for Github Action workflow script - -c-sharp: - - changed-files: - - any-glob-to-any-file: - - '**/*.cs' - - 'net/**/*' - - 'tests/FlatBuffers.Test/**/*' - - 'tests/FlatBuffers.Benchmarks/**/*' - - 'src/idl_gen_csharp.cpp' - -swift: - - changed-files: - - any-glob-to-any-file: - - '**/*.swift' - - 'swift/**/*' - - 'tests/swift/**' - - 'src/idl_gen_swift.cpp' - -nim: - - changed-files: - - any-glob-to-any-file: - - '**/*.nim' - - 'nim/**/*' - - 'src/idl_gen_nim.cpp' - - 'src/bfbs_gen_nim.cpp' - -javascript: - - changed-files: - - any-glob-to-any-file: - - '**/*.js' - - 'src/idl_gen_ts.cpp' - -typescript: - - changed-files: - - any-glob-to-any-file: - - '**/*.ts' - - 'src/idl_gen_ts.cpp' - - 'grpc/flatbuffers-js-grpc/**/*.ts' - -golang: - - changed-files: - - any-glob-to-any-file: - - '**/*.go' - - 'src/idl_gen_go.cpp' - -python: - - changed-files: - - any-glob-to-any-file: - - '**/*.py' - - 'src/idl_gen_python.cpp' - -java: - - changed-files: - - any-glob-to-any-file: - - '**/*.java' - - 'src/idl_gen_java.cpp' - -kotlin: - - changed-files: - - any-glob-to-any-file: - - '**/*.kt' - - 'src/idl_gen_kotlin.cpp' - - 'src/idl_gen_kotlin_kmp.cpp' - -lua: - - changed-files: - - any-glob-to-any-file: - - '**/*.lua' - - 'lua/**/*' - - 'src/bfbs_gen_lua.cpp' - -lobster: - - changed-files: - - any-glob-to-any-file: - - '**/*.lobster' - - 'src/idl_gen_lobster.cpp' - -php: - - changed-files: - - any-glob-to-any-file: - - '**/*.php' - - 'src/idl_gen_php.cpp' - -rust: - - changed-files: - - any-glob-to-any-file: - - '**/*.rs' - - 'rust/**/*' - - 'src/idl_gen_rust.cpp' - -dart: - - changed-files: - - any-glob-to-any-file: - - '**/*.dart' - - 'src/idl_gen_dart.cpp' - -cpp: - - changed-files: - - any-glob-to-any-file: - - '**/*.cc' - - '**/*.cpp' - - '**/*.h' - -json: - - changed-files: - - any-glob-to-any-file: - - '**/*.json' - - 'src/idl_gen_json_schema.cpp' - -codegen: - - changed-files: - - any-glob-to-any-file: - - 'src/**/*' - -documentation: - - changed-files: - - any-glob-to-any-file: - - 'docs/**/*' - - '**/*.md' - -CI: - - changed-files: - - any-glob-to-any-file: - - '.github/**/*' - - '.bazelci/**/*' - -grpc: - - changed-files: - - any-glob-to-any-file: - - 'grpc/**/*' - - 'src/idl_gen_grpc.cpp' +labels: + "c#": + - changed-files: + - any-glob-to-any-file: + - '**/*.cs' + - 'net/**/*' + - 'tests/FlatBuffers.Test/**/*' + - 'tests/FlatBuffers.Benchmarks/**/*' + - 'src/idl_gen_csharp.cpp' + + swift: + - changed-files: + - any-glob-to-any-file: + - '**/*.swift' + - 'swift/**/*' + - 'tests/swift/**' + - 'src/idl_gen_swift.cpp' + + nim: + - changed-files: + - any-glob-to-any-file: + - '**/*.nim' + - 'nim/**/*' + - 'src/idl_gen_nim.cpp' + - 'src/bfbs_gen_nim.cpp' + + javascript: + - changed-files: + - any-glob-to-any-file: + - '**/*.js' + - 'src/idl_gen_ts.cpp' + + typescript: + - changed-files: + - any-glob-to-any-file: + - '**/*.ts' + - 'src/idl_gen_ts.cpp' + - 'grpc/flatbuffers-js-grpc/**/*.ts' + + golang: + - changed-files: + - any-glob-to-any-file: + - '**/*.go' + - 'src/idl_gen_go.cpp' + + python: + - changed-files: + - any-glob-to-any-file: + - '**/*.py' + - 'src/idl_gen_python.cpp' + + java: + - changed-files: + - any-glob-to-any-file: + - '**/*.java' + - 'src/idl_gen_java.cpp' + + kotlin: + - changed-files: + - any-glob-to-any-file: + - '**/*.kt' + - 'src/idl_gen_kotlin.cpp' + - 'src/idl_gen_kotlin_kmp.cpp' + + lua: + - changed-files: + - any-glob-to-any-file: + - '**/*.lua' + - 'lua/**/*' + - 'src/bfbs_gen_lua.cpp' + + lobster: + - changed-files: + - any-glob-to-any-file: + - '**/*.lobster' + - 'src/idl_gen_lobster.cpp' + + php: + - changed-files: + - any-glob-to-any-file: + - '**/*.php' + - 'src/idl_gen_php.cpp' + + rust: + - changed-files: + - any-glob-to-any-file: + - '**/*.rs' + - 'rust/**/*' + - 'src/idl_gen_rust.cpp' + + dart: + - changed-files: + - any-glob-to-any-file: + - '**/*.dart' + - 'src/idl_gen_dart.cpp' + + "c++": + - changed-files: + - any-glob-to-any-file: + - '**/*.cc' + - '**/*.cpp' + - '**/*.h' + + json: + - changed-files: + - any-glob-to-any-file: + - '**/*.json' + - 'src/idl_gen_json_schema.cpp' + + codegen: + - changed-files: + - any-glob-to-any-file: + - 'src/**/*' + + documentation: + - changed-files: + - any-glob-to-any-file: + - 'docs/**/*' + - '**/*.md' + + CI: + - changed-files: + - any-glob-to-any-file: + - '.github/**/*' + - '.bazelci/**/*' + + grpc: + - changed-files: + - any-glob-to-any-file: + - 'grpc/**/*' + - 'src/idl_gen_grpc.cpp' From 19120824d17a769a28ee1a635c15bd245eddbcfd Mon Sep 17 00:00:00 2001 From: Joe Jones Date: Wed, 5 Aug 2026 11:07:19 -0700 Subject: [PATCH 2/6] Let's see if this works. Simplified the label configuration for C# by merging its rules into a single line. --- .github/labeler.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/labeler.yml b/.github/labeler.yml index 7f33be833..9ecd27af8 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -1,12 +1,5 @@ labels: - "c#": - - changed-files: - - any-glob-to-any-file: - - '**/*.cs' - - 'net/**/*' - - 'tests/FlatBuffers.Test/**/*' - - 'tests/FlatBuffers.Benchmarks/**/*' - - 'src/idl_gen_csharp.cpp' + c#: ['**/*.cs', 'net/**/*', 'tests/FlatBuffers.Test/**/*', 'tests/FlatBuffers.Benchmarks/**/*', 'src/idl_gen_csharp.cpp'] swift: - changed-files: From 191eab2bb2878e36a6197eef2170d88cea72ddcc Mon Sep 17 00:00:00 2001 From: Joe Jones Date: Wed, 5 Aug 2026 11:09:48 -0700 Subject: [PATCH 3/6] Force to use v5. --- .github/labeler.yml | 262 +++++++++++++++++++++++--------------------- 1 file changed, 138 insertions(+), 124 deletions(-) diff --git a/.github/labeler.yml b/.github/labeler.yml index 9ecd27af8..c787d91b6 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -1,124 +1,138 @@ -labels: - c#: ['**/*.cs', 'net/**/*', 'tests/FlatBuffers.Test/**/*', 'tests/FlatBuffers.Benchmarks/**/*', 'src/idl_gen_csharp.cpp'] - - swift: - - changed-files: - - any-glob-to-any-file: - - '**/*.swift' - - 'swift/**/*' - - 'tests/swift/**' - - 'src/idl_gen_swift.cpp' - - nim: - - changed-files: - - any-glob-to-any-file: - - '**/*.nim' - - 'nim/**/*' - - 'src/idl_gen_nim.cpp' - - 'src/bfbs_gen_nim.cpp' - - javascript: - - changed-files: - - any-glob-to-any-file: - - '**/*.js' - - 'src/idl_gen_ts.cpp' - - typescript: - - changed-files: - - any-glob-to-any-file: - - '**/*.ts' - - 'src/idl_gen_ts.cpp' - - 'grpc/flatbuffers-js-grpc/**/*.ts' - - golang: - - changed-files: - - any-glob-to-any-file: - - '**/*.go' - - 'src/idl_gen_go.cpp' - - python: - - changed-files: - - any-glob-to-any-file: - - '**/*.py' - - 'src/idl_gen_python.cpp' - - java: - - changed-files: - - any-glob-to-any-file: - - '**/*.java' - - 'src/idl_gen_java.cpp' - - kotlin: - - changed-files: - - any-glob-to-any-file: - - '**/*.kt' - - 'src/idl_gen_kotlin.cpp' - - 'src/idl_gen_kotlin_kmp.cpp' - - lua: - - changed-files: - - any-glob-to-any-file: - - '**/*.lua' - - 'lua/**/*' - - 'src/bfbs_gen_lua.cpp' - - lobster: - - changed-files: - - any-glob-to-any-file: - - '**/*.lobster' - - 'src/idl_gen_lobster.cpp' - - php: - - changed-files: - - any-glob-to-any-file: - - '**/*.php' - - 'src/idl_gen_php.cpp' - - rust: - - changed-files: - - any-glob-to-any-file: - - '**/*.rs' - - 'rust/**/*' - - 'src/idl_gen_rust.cpp' - - dart: - - changed-files: - - any-glob-to-any-file: - - '**/*.dart' - - 'src/idl_gen_dart.cpp' - - "c++": - - changed-files: - - any-glob-to-any-file: - - '**/*.cc' - - '**/*.cpp' - - '**/*.h' - - json: - - changed-files: - - any-glob-to-any-file: - - '**/*.json' - - 'src/idl_gen_json_schema.cpp' - - codegen: - - changed-files: - - any-glob-to-any-file: - - 'src/**/*' - - documentation: - - changed-files: - - any-glob-to-any-file: - - 'docs/**/*' - - '**/*.md' - - CI: - - changed-files: - - any-glob-to-any-file: - - '.github/**/*' - - '.bazelci/**/*' - - grpc: - - changed-files: - - any-glob-to-any-file: - - 'grpc/**/*' - - 'src/idl_gen_grpc.cpp' +# Configuration for Auto Labeler during pull request +# +# See https://github.com/actions/labeler for file format +# and https://github.com/google/flatbuffers/labels for a list of valid labels +# +# See .github/workflows/label.yml for Github Action workflow script +- uses: actions/labeler@v5 + +"c#": + - changed-files: + - any-glob-to-any-file: + - '**/*.cs' + - 'net/**/*' + - 'tests/FlatBuffers.Test/**/*' + - 'tests/FlatBuffers.Benchmarks/**/*' + - 'src/idl_gen_csharp.cpp' + +swift: + - changed-files: + - any-glob-to-any-file: + - '**/*.swift' + - 'swift/**/*' + - 'tests/swift/**' + - 'src/idl_gen_swift.cpp' + +nim: + - changed-files: + - any-glob-to-any-file: + - '**/*.nim' + - 'nim/**/*' + - 'src/idl_gen_nim.cpp' + - 'src/bfbs_gen_nim.cpp' + +javascript: + - changed-files: + - any-glob-to-any-file: + - '**/*.js' + - 'src/idl_gen_ts.cpp' + +typescript: + - changed-files: + - any-glob-to-any-file: + - '**/*.ts' + - 'src/idl_gen_ts.cpp' + - 'grpc/flatbuffers-js-grpc/**/*.ts' + +golang: + - changed-files: + - any-glob-to-any-file: + - '**/*.go' + - 'src/idl_gen_go.cpp' + +python: + - changed-files: + - any-glob-to-any-file: + - '**/*.py' + - 'src/idl_gen_python.cpp' + +java: + - changed-files: + - any-glob-to-any-file: + - '**/*.java' + - 'src/idl_gen_java.cpp' + +kotlin: + - changed-files: + - any-glob-to-any-file: + - '**/*.kt' + - 'src/idl_gen_kotlin.cpp' + - 'src/idl_gen_kotlin_kmp.cpp' + +lua: + - changed-files: + - any-glob-to-any-file: + - '**/*.lua' + - 'lua/**/*' + - 'src/bfbs_gen_lua.cpp' + +lobster: + - changed-files: + - any-glob-to-any-file: + - '**/*.lobster' + - 'src/idl_gen_lobster.cpp' + +php: + - changed-files: + - any-glob-to-any-file: + - '**/*.php' + - 'src/idl_gen_php.cpp' + +rust: + - changed-files: + - any-glob-to-any-file: + - '**/*.rs' + - 'rust/**/*' + - 'src/idl_gen_rust.cpp' + +dart: + - changed-files: + - any-glob-to-any-file: + - '**/*.dart' + - 'src/idl_gen_dart.cpp' + +"c++": + - changed-files: + - any-glob-to-any-file: + - '**/*.cc' + - '**/*.cpp' + - '**/*.h' + +json: + - changed-files: + - any-glob-to-any-file: + - '**/*.json' + - 'src/idl_gen_json_schema.cpp' + +codegen: + - changed-files: + - any-glob-to-any-file: + - 'src/**/*' + +documentation: + - changed-files: + - any-glob-to-any-file: + - 'docs/**/*' + - '**/*.md' + +CI: + - changed-files: + - any-glob-to-any-file: + - '.github/**/*' + - '.bazelci/**/*' + +grpc: + - changed-files: + - any-glob-to-any-file: + - 'grpc/**/*' + - 'src/idl_gen_grpc.cpp' From eb71fe71e369f02f88cf50d554f037d24aec4133 Mon Sep 17 00:00:00 2001 From: Joe Jones Date: Wed, 5 Aug 2026 11:11:37 -0700 Subject: [PATCH 4/6] Update labeler.yml to include 'any' --- .github/labeler.yml | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/.github/labeler.yml b/.github/labeler.yml index c787d91b6..3f997ebd6 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -7,13 +7,14 @@ - uses: actions/labeler@v5 "c#": - - changed-files: - - any-glob-to-any-file: - - '**/*.cs' - - 'net/**/*' - - 'tests/FlatBuffers.Test/**/*' - - 'tests/FlatBuffers.Benchmarks/**/*' - - 'src/idl_gen_csharp.cpp' + - any: + - changed-files: + - any-glob-to-any-file: + - '**/*.cs' + - 'net/**/*' + - 'tests/FlatBuffers.Test/**/*' + - 'tests/FlatBuffers.Benchmarks/**/*' + - 'src/idl_gen_csharp.cpp' swift: - changed-files: From 8c2998862c1652063e2b225e05c5bdf8cccd7d27 Mon Sep 17 00:00:00 2001 From: Joe Jones Date: Wed, 5 Aug 2026 11:12:17 -0700 Subject: [PATCH 5/6] Remove c# for testing. --- .github/labeler.yml | 9 --------- 1 file changed, 9 deletions(-) diff --git a/.github/labeler.yml b/.github/labeler.yml index 3f997ebd6..4787bf79a 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -6,15 +6,6 @@ # See .github/workflows/label.yml for Github Action workflow script - uses: actions/labeler@v5 -"c#": - - any: - - changed-files: - - any-glob-to-any-file: - - '**/*.cs' - - 'net/**/*' - - 'tests/FlatBuffers.Test/**/*' - - 'tests/FlatBuffers.Benchmarks/**/*' - - 'src/idl_gen_csharp.cpp' swift: - changed-files: From 70b6a4d6a6b31b356b64e5836c00eafcc5708aa5 Mon Sep 17 00:00:00 2001 From: Joe Jones Date: Wed, 5 Aug 2026 11:18:09 -0700 Subject: [PATCH 6/6] That didn't work --- .github/labeler.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/labeler.yml b/.github/labeler.yml index 4787bf79a..b89019605 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -4,8 +4,15 @@ # and https://github.com/google/flatbuffers/labels for a list of valid labels # # See .github/workflows/label.yml for Github Action workflow script -- uses: actions/labeler@v5 +c#: + - changed-files: + - any-glob-to-any-file: + - '**/*.cs' + - 'net/**/*' + - 'tests/FlatBuffers.Test/**/*' + - 'tests/FlatBuffers.Benchmarks/**/*' + - 'src/idl_gen_csharp.cpp' swift: - changed-files: