Skip to content

Commit a2e53a2

Browse files
committed
fixed CI + addressed U-PR comments
1 parent f6b26a2 commit a2e53a2

3 files changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/pr-description-validation.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ jobs:
3535
// This should be automations where we don't care that much about the description format
3636
const skipUserPatterns = [
3737
/^unity-renovate/,
38-
/svc/
38+
/^svc-/
3939
];
4040
4141
// If PR author matches the skip list, exit early

com.unity.netcode.gameobjects/Tests/Runtime/Messaging/MessageReceiveAllocationTests.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ public void NotMeRpc()
2323

2424
[TestFixture(HostOrServer.Host)]
2525
[TestFixture(HostOrServer.DAHost)]
26+
[UnityCoreClrExplicitDisabled("https://jira.unity3d.com/browse/UUM-149591", "NGO multi-instance test sessions fail to start/connect or time out on CoreCLR")]
2627
internal class MessageReceiveAllocationTests : NetcodeIntegrationTest
2728
{
2829
protected override int NumberOfClients => 1;

com.unity.netcode.gameobjects/Tests/Runtime/Unity.Netcode.Runtime.Tests.asmdef

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,8 @@
5454
"name": "com.unity.netcode",
5555
"expression": "1.10.1",
5656
"define": "UNIFIED_NETCODE"
57-
},
57+
},
58+
{
5859
"name": "com.unity.test-framework",
5960
"expression": "1.7.0",
6061
"define": "UNITY_TEST_FRAMEWORK_1_7_OR_NEWER"

0 commit comments

Comments
 (0)