chore: asmdef guid references (#4152)

* chore: reference the Netcode for Entities assemblies by GUID

Three asmdefs named "Unity.NetCode" and "Unity.NetCode.Editor" as strings. Unity silently drops an
asmdef reference it cannot resolve, so renaming either assembly would make every UNIFIED_NETCODE code
path fail to compile with nothing pointing at the cause. A GUID reference resolves to whichever
asmdef asset carries that GUID regardless of the name inside it, which is how NGO's own editor
assembly rename stayed transparent to projects referencing it.

The GUIDs are read from the installed package's .asmdef.meta files, not derived:
  Unity.NetCode         953adc2a6b8b4e3c8df5b728bcd546e9
  Unity.NetCode.Editor  eb8cf780bf058694ebf7ec5cf5b8cfa3

Unity.Entities is left by name. It is not the assembly at risk of a rename, and converting it would
add surface that cannot be checked here for no benefit.

Not verified locally: confirming a GUID reference resolves needs an editor with both packages
installed. Worth an import in a project that has Netcode for Entities before this is relied on - if a
GUID is wrong the reference drops silently, which is the failure this is meant to prevent.

* chore: rename the internal NetworkMetrics to ToolsNetworkMetrics

The last of the three type names NGO and Netcode for Entities share. This one is internal, so no user
sees it and it is not a compile error either way: a source-declared type beats an imported one, so
NGO's own assembly would take its own and warn CS0436. But once the two namespaces converge the
warning appears in our build log for a name nobody can act on from outside, and "Unity.Netcode holds
no name that collides" is a simpler thing to be able to say than "two of the three".

ToolsNetworkMetrics keeps the suffix, so it still reads as a pair with its sibling
NullNetworkMetrics - the two INetworkMetrics implementations, one behind MULTIPLAYER_TOOLS and one
not.

Five sites in two files: the declaration, both constructors, the profiler marker and the single
construction site. Everything else that reads NetworkMetrics is a property of that name on
NetworkManager, NetworkMetricsManager or NetworkTransport, all typed INetworkMetrics and untouched.

The profiler marker keeps its old string rather than following the rename. It is what shows up in the
Profiler, and an internal rename is not a reason to move it, so nameof gives way to the literal with
a comment saying why.

Verified as far as this machine allows: runtime, editor and runtime tests all compile clean, which
covers the #else branch. The renamed class is entirely inside #if MULTIPLAYER_TOOLS and the harness
has no Unity.Multiplayer.Tools references, so that branch cannot be built here. A parse pass over the
file with the define on reports only CS0246/CS0234 for the tools types and no structural error, which
is what a class and constructor disagreeing on a name would produce. The define-on path still wants a
real editor build before this is trusted.

---------

Co-authored-by: Michał Chrobot <124174716+michalChrobot@users.noreply.github.com>

Author: NoelStephensUnity

com.unity.netcode.gameobjects/Editor/Unity.Netcode.Editor.asmdef

@@ -8,8 +8,8 @@
         "Unity.Networking.Transport",
         "Unity.Services.Core",
         "Unity.Services.Authentication",
-        "Unity.NetCode",
-        "Unity.NetCode.Editor"
+        "GUID:953adc2a6b8b4e3c8df5b728bcd546e9",
+        "GUID:eb8cf780bf058694ebf7ec5cf5b8cfa3"
     ],
     "includePlatforms": [
         "Editor"

com.unity.netcode.gameobjects/Runtime/Metrics/NetworkMetricsManager.cs

@@ -27,7 +27,7 @@ public void Initialize(NetworkManager networkManager)
             if (NetworkMetrics == null)
             {
 #if MULTIPLAYER_TOOLS
-                NetworkMetrics = new NetworkMetrics();
+                NetworkMetrics = new ToolsNetworkMetrics();
 #else
                 NetworkMetrics = new NullNetworkMetrics();
 #endif

…bjects/Runtime/Metrics/NetworkMetrics.cs …s/Runtime/Metrics/ToolsNetworkMetrics.cscom.unity.netcode.gameobjects/Runtime/Metrics/NetworkMetrics.cs renamed to com.unity.netcode.gameobjects/Runtime/Metrics/ToolsNetworkMetrics.cs com.unity.netcode.gameobjects/Runtime/Metrics/NetworkMetrics.cs renamed to com.unity.netcode.gameobjects/Runtime/Metrics/ToolsNetworkMetrics.cs

@@ -8,20 +8,22 @@
 
 namespace Unity.Netcode
 {
-    internal class NetworkMetrics : INetworkMetrics
+    internal class ToolsNetworkMetrics : INetworkMetrics
     {
         private const ulong k_MaxMetricsPerFrame = 1000L;
         private static readonly Dictionary<uint, string> k_SceneEventTypeNames;
         private static readonly ProfilerMarker k_FrameDispatch;
 
-        static NetworkMetrics()
+        static ToolsNetworkMetrics()
         {
             k_SceneEventTypeNames = new Dictionary<uint, string>();
             foreach (SceneEventType type in Enum.GetValues(typeof(SceneEventType)))
             {
                 k_SceneEventTypeNames[(uint)type] = type.ToString();
             }
-            k_FrameDispatch = new ProfilerMarker($"{nameof(NetworkMetrics)}.DispatchFrame");
+            // Spelled out rather than nameof: this is the name shown in the Profiler, and it
+            // should not move because the implementing type was renamed.
+            k_FrameDispatch = new ProfilerMarker("NetworkMetrics.DispatchFrame");
         }
 
         private static string GetSceneEventTypeName(uint typeCode)
@@ -85,7 +87,7 @@ private static string GetSceneEventTypeName(uint typeCode)
 
         private ulong m_NumberOfMetricsThisFrame;
 
-        public NetworkMetrics()
+        public ToolsNetworkMetrics()
         {
             Dispatcher = new MetricDispatcherBuilder()
                 .WithCounters(m_TransportBytesSent, m_TransportBytesReceived)

…s/Runtime/Metrics/NetworkMetrics.cs.meta …time/Metrics/ToolsNetworkMetrics.cs.metacom.unity.netcode.gameobjects/Runtime/Metrics/NetworkMetrics.cs.meta renamed to com.unity.netcode.gameobjects/Runtime/Metrics/ToolsNetworkMetrics.cs.meta com.unity.netcode.gameobjects/Runtime/Metrics/NetworkMetrics.cs.meta renamed to com.unity.netcode.gameobjects/Runtime/Metrics/ToolsNetworkMetrics.cs.meta

@@ -14,7 +14,7 @@
         "Unity.Collections",
         "Unity.Burst",
         "Unity.Mathematics",
-        "Unity.NetCode",
+        "GUID:953adc2a6b8b4e3c8df5b728bcd546e9",
         "Unity.Entities"
     ],
     "includePlatforms": [],

com.unity.netcode.gameobjects/Runtime/Unity.Netcode.Runtime.asmdef

@@ -14,7 +14,7 @@
         "Unity.Mathematics",
         "UnityEngine.TestRunner",
         "UnityEditor.TestRunner",
-        "Unity.NetCode",
+        "GUID:953adc2a6b8b4e3c8df5b728bcd546e9",
         "Unity.Entities"
     ],
     "includePlatforms": [],