test: record that the updater does not follow namespace aliases

The assertion added in 9022abd failed on CI, which is the informative outcome rather than a
broken assertion: 'TimeNs.NetworkTickSystem' survived the update, so Unity's API updater does not
rewrite a reference reached through a namespace alias.

The mechanism looks to be that the alias itself still resolves - Unity.Netcode is very much alive -
so only the member lookup inside it fails, and that is not a trigger. The same run shows the other
two NetworkTickSystem sites migrating, the plain simple name among them, so this is specific to the
alias form and not a general gap in what the updater covers.

The expectation is therefore inverted to 'blocked', recording the limitation the way --collision-stub
already records the resolution-failure one, and UNQUALIFIED_FORMS becomes a map so a form can be
declared either way. Documented in the README and noted in the CHANGELOG, since a user who writes
references this way has to fix them by hand - loudly, as a compile error naming the type, rather
than silently.

Author: NoelStephensUnity

apiupdaterproject/README.md

@@ -84,6 +84,18 @@ reference to `NetworkTimeSystem` still resolves — to the stub — so it never
 If a future change ever makes the blocked row pass as "rewritten", the mechanism has changed and the
 one-sided-move conclusion needs revisiting.
 
+### One reference form the updater does not migrate
+
+`DeprecatedTimingUsage.cs` reaches `NetworkTickSystem` through a namespace alias
+(`using TimeNs = Unity.Netcode;` then `TimeNs.NetworkTickSystem`). The updater leaves that site alone,
+measured on CI. The alias itself still resolves - `Unity.Netcode` is very much alive - so only the
+member lookup inside it fails, and that does not appear to trigger a rewrite. Every other form in that
+file migrates, including the plain simple name.
+
+The run asserts this as `blocked` rather than treating it as a bug to fix here. A user who writes
+references that way gets a compile error naming the type, so it is loud rather than silent, but it is
+worth knowing when someone reports that the upgrade "did not finish".
+
 Default hub locations, if you need to pass `--unity` explicitly — note that on macOS the binary is
 inside the `.app` bundle rather than beside it:
 

apiupdaterproject/run_upgrade_test.py

@@ -74,11 +74,17 @@
 
 
 # Reference forms the per-type counts above cannot see, because the source never spells the type's
-# fully qualified name. 'TimeNs.NetworkTickSystem' in DeprecatedTimingUsage.cs goes through a
-# namespace alias and so matches neither the old nor the new spelling: without asserting on it
-# directly, the updater could leave that site unresolved and the run would still pass on the strength
-# of the other reference forms. The editor runs with -ignoreCompilerErrors, so nothing else catches it.
-UNQUALIFIED_FORMS = ['TimeNs.NetworkTickSystem']
+# fully qualified name, mapped to what the updater does with them.
+#
+# 'TimeNs.NetworkTickSystem' reaches the type through a namespace alias
+# ('using TimeNs = Unity.Netcode;'). The updater does not rewrite it - measured on CI, not assumed.
+# The alias itself still resolves, since Unity.Netcode is very much alive; only the member lookup
+# inside it fails, and that is apparently not a trigger. So this records the limitation, the same way
+# --collision-stub does, rather than asserting a fix that does not exist. A user who writes their
+# references this way gets a compile error naming the type and has to update it by hand.
+UNQUALIFIED_FORMS = {
+    'TimeNs.NetworkTickSystem': 'blocked',
+}
 
 
 def expected_pairs():
@@ -277,12 +283,12 @@ def assert_rewritten(collision_stub):
         expect = 'blocked' if blocked else 'moved'
         print(f"{old:<72} {updated:>8} {stale:>6} {expect:>8}  {'PASS' if passed else 'FAIL'}")
 
-    for form in UNQUALIFIED_FORMS:
+    for form, expect in UNQUALIFIED_FORMS.items():
         survived = len(re.findall(re.escape(form) + boundary, all_text))
-        passed = survived == 0
+        passed = survived > 0 if expect == 'blocked' else survived == 0
         if not passed:
             failures += 1
-        print(f"{form:<72} {'-':>8} {survived:>6} {'moved':>8}  {'PASS' if passed else 'FAIL'}")
+        print(f"{form:<72} {'-':>8} {survived:>6} {expect:>8}  {'PASS' if passed else 'FAIL'}")
 
     return failures
 

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -19,7 +19,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
   - `Unity.Netcode.Editor.CodeGen` → `Unity.Netcode.GameObjects.Editor.CodeGen`
   - `Unity.Netcode.Editor.PackageChecker` → `Unity.Netcode.GameObjects.Editor.PackageChecker`
   - `Unity.Netcode.Editor.Tests` → `Unity.Netcode.GameObjects.Editor.Tests`
-- The timing types moved out of the `Unity.Netcode` namespace into `Unity.Netcode.GameObjects.Timing`. The assembly is unchanged, and existing scripts are migrated automatically when the package is upgraded. The exception is a reference another installed package still resolves under `Unity.Netcode`: the updater only rewrites references that fail to resolve, so those have to be updated by hand.
+- The timing types moved out of the `Unity.Netcode` namespace into `Unity.Netcode.GameObjects.Timing`. The assembly is unchanged, and existing scripts are migrated automatically when the package is upgraded. The exception is a reference another installed package still resolves under `Unity.Netcode`: the updater only rewrites references that fail to resolve, so those have to be updated by hand. A reference reached through a namespace alias is also left alone, and reports as a compile error naming the type.
   - `Unity.Netcode.NetworkTime` → `Unity.Netcode.GameObjects.Timing.NetworkTime`
   - `Unity.Netcode.NetworkTimeSystem` → `Unity.Netcode.GameObjects.Timing.NetworkTimeSystem`
   - `Unity.Netcode.NetworkTickSystem` → `Unity.Netcode.GameObjects.Timing.NetworkTickSystem`