Made more obsolete apis throw errors

Author: michalChrobot

com.unity.netcode.gameobjects/CHANGELOG.md

@@ -17,6 +17,7 @@ Additional documentation and release notes are available at [Multiplayer Documen
   - `Unity.Netcode.Editor.CodeGen` → `Unity.Netcode.GameObjects.Editor.CodeGen`
   - `Unity.Netcode.Editor.PackageChecker` → `Unity.Netcode.GameObjects.Editor.PackageChecker`
   - `Unity.Netcode.Editor.Tests` → `Unity.Netcode.GameObjects.Editor.Tests`
+- Several APIs that were already marked `[Obsolete]` with a warning now raise a compile error instead (they are not removed yet): `NetworkObject.IsSceneObject`, `NetworkObject.SetSceneObjectStatus`, `NetworkList.LastModifiedTick`, `UnityTransport.InitialMaxSendQueueSize`, `UnityTransport.DebugSimulator`, `UnityTransport.SetDebugSimulatorParameters`, the deprecated `BufferedLinearInterpolator` buffer/interpolation fields and its testing-only `Update(float, NetworkTime)` overload, `NetworkSpawnManager.InternalOnOwnershipChanged`, `CommandLineOptions.Instance`, `CommandLineOptions.GetArg`, and `NotListeningException`.
 
 ### Deprecated
 

com.unity.netcode.gameobjects/Editor/CodeGen/RuntimeAccessModifiersILPP.cs

@@ -97,33 +97,25 @@ private void ProcessNetworkManager(TypeDefinition typeDefinition, string[] assem
         {
             foreach (var fieldDefinition in typeDefinition.Fields)
             {
-#pragma warning disable CS0618 // Type or member is obsolete
-                if (fieldDefinition.Name == nameof(NetworkManager.__rpc_func_table))
-#pragma warning restore CS0618 // Type or member is obsolete
+                if (fieldDefinition.Name == "__rpc_func_table")
                 {
                     fieldDefinition.IsPublic = true;
                 }
 
-#pragma warning disable CS0618 // Type or member is obsolete
-                if (fieldDefinition.Name == nameof(NetworkManager.RpcReceiveHandler))
-#pragma warning restore CS0618 // Type or member is obsolete
+                if (fieldDefinition.Name == "RpcReceiveHandler")
                 {
                     fieldDefinition.IsPublic = true;
                 }
 
-#pragma warning disable CS0618 // Type or member is obsolete
-                if (fieldDefinition.Name == nameof(NetworkManager.__rpc_name_table))
-#pragma warning restore CS0618 // Type or member is obsolete
+                if (fieldDefinition.Name == "__rpc_name_table")
                 {
                     fieldDefinition.IsPublic = true;
                 }
             }
 
             foreach (var nestedTypeDefinition in typeDefinition.NestedTypes)
             {
-#pragma warning disable CS0618 // Type or member is obsolete
-                if (nestedTypeDefinition.Name == nameof(NetworkManager.RpcReceiveHandler))
-#pragma warning restore CS0618 // Type or member is obsolete
+                if (nestedTypeDefinition.Name == "RpcReceiveHandler")
                 {
                     nestedTypeDefinition.IsNestedPublic = true;
                 }

com.unity.netcode.gameobjects/Editor/NetworkObjectEditor.cs

@@ -101,10 +101,7 @@ public override void OnInspectorGUI()
                 EditorGUILayout.Toggle(nameof(NetworkObject.IsOwner), m_NetworkObject.IsOwner);
                 EditorGUILayout.Toggle(nameof(NetworkObject.IsOwnedByServer), m_NetworkObject.IsOwnedByServer);
                 EditorGUILayout.Toggle(nameof(NetworkObject.IsPlayerObject), m_NetworkObject.IsPlayerObject);
-#pragma warning disable CS0618 // Type or member is obsolete
-                // TODO-3.x: Update name in 3.x branch
-                EditorGUILayout.Toggle(nameof(NetworkObject.IsSceneObject), m_NetworkObject.InScenePlaced);
-#pragma warning restore CS0618 // Type or member is obsolete
+                EditorGUILayout.Toggle("IsSceneObject", m_NetworkObject.InScenePlaced);
                 EditorGUILayout.Toggle(nameof(NetworkObject.DestroyWithScene), m_NetworkObject.DestroyWithScene);
                 EditorGUILayout.TextField(nameof(NetworkObject.NetworkManager), m_NetworkObject.NetworkManager == null ? "null" : m_NetworkObject.NetworkManager.gameObject.name);
                 GUI.enabled = guiEnabled;

com.unity.netcode.gameobjects/Runtime/Components/Interpolator/BufferedLinearInterpolator.cs

@@ -59,28 +59,28 @@ private float GetPrecision()
         /// <remarks>
         /// This is replaced by the <see cref="m_BufferQueue"/> of type <see cref="Queue{T}"/>.
         /// </remarks>
-        [Obsolete("This list is no longer used and will be deprecated.", false)]
+        [Obsolete("This list is no longer used and will be deprecated.", true)]
         protected internal readonly List<BufferedItem> m_Buffer = new List<BufferedItem>();
 
         /// <summary>
         /// ** Deprecating **
         /// The starting value of type <see cref="T"/> to interpolate from.
         /// </summary>
-        [Obsolete("This property will be deprecated.", false)]
+        [Obsolete("This property will be deprecated.", true)]
         protected internal T m_InterpStartValue;
 
         /// <summary>
         /// ** Deprecating **
         /// The current value of type <see cref="T"/>.
         /// </summary>
-        [Obsolete("This property will be deprecated.", false)]
+        [Obsolete("This property will be deprecated.", true)]
         protected internal T m_CurrentInterpValue;
 
         /// <summary>
         /// ** Deprecating **
         /// The end (or target) value of type <see cref="T"/> to interpolate towards.
         /// </summary>
-        [Obsolete("This property will be deprecated.", false)]
+        [Obsolete("This property will be deprecated.", true)]
         protected internal T m_InterpEndValue;
         #endregion
 
@@ -651,7 +651,7 @@ public T Update(float deltaTime, double renderTime, double serverTime)
         /// <param name="deltaTime">time since call</param>
         /// <param name="serverTime">current server time</param>
         /// <returns>The newly interpolated value of type 'T'</returns>
-        [Obsolete("This method is being deprecated due to it being only used for internal testing purposes.", false)]
+        [Obsolete("This method is being deprecated due to it being only used for internal testing purposes.", true)]
         public T Update(float deltaTime, NetworkTime serverTime)
         {
             return UpdateInternal(deltaTime, serverTime);

com.unity.netcode.gameobjects/Runtime/Configuration/CommandLineOptions.cs

@@ -12,7 +12,7 @@ public class CommandLineOptions
         /// <summary>
         /// Command-line options singleton
         /// </summary>
-        [Obsolete("Not used anymore replaced by TryGetArg")]
+        [Obsolete("Not used anymore replaced by TryGetArg", true)]
         public static CommandLineOptions Instance
         {
             get
@@ -38,7 +38,7 @@ private set
         /// </summary>
         /// <param name="arg">The name of the argument</param>
         /// <returns><see cref="string"/>Value of the command line argument passed in.</returns>
-        [Obsolete("Not used anymore replaced by TryGetArg")]
+        [Obsolete("Not used anymore replaced by TryGetArg", true)]
         public string GetArg(string arg)
         {
             var argIndex = k_CommandLineArguments.IndexOf(arg);

com.unity.netcode.gameobjects/Runtime/Connection/NetworkConnectionManager.cs

@@ -1189,11 +1189,7 @@ internal void CreateAndSpawnPlayer(ulong ownerId)
                 return;
             }
 
-#pragma warning disable CS0618 // Type or member is obsolete
-            // Obsolete with warning means we need the underlying behaviour to keep existing
-            // TODO: remove in the 3.x branch
-            networkObject.SetSceneObjectStatus(false);
-#pragma warning restore CS0618 // Type or member is obsolete
+            networkObject.IsSceneObjectInternal = false;
             networkObject.NetworkManagerOwner = NetworkManager;
             networkObject.SpawnAsPlayerObject(ownerId, networkObject.DestroyWithScene);
         }

com.unity.netcode.gameobjects/Runtime/Core/NetworkManager.cs

@@ -71,15 +71,15 @@ private static void ResetStaticsOnLoad()
 #pragma warning disable IDE1006 // disable naming rule violation check
 
         // RuntimeAccessModifiersILPP will make this `public`
-        [Obsolete("This field is no longer used and will be removed in a future version.")]
+        [Obsolete("This field is no longer used and will be removed in a future version.", true)]
         internal delegate void RpcReceiveHandler(NetworkBehaviour behaviour, FastBufferReader reader, __RpcParams parameters);
 
         // RuntimeAccessModifiersILPP will make this `public`
-        [Obsolete("This field is no longer used and will be removed in a future version.")]
+        [Obsolete("This field is no longer used and will be removed in a future version.", true)]
         internal static readonly Dictionary<uint, RpcReceiveHandler> __rpc_func_table = new Dictionary<uint, RpcReceiveHandler>();
 
         // RuntimeAccessModifiersILPP will make this `public` (legacy table should be removed in v3.x.x)
-        [Obsolete("This field is no longer used and will be removed in a future version.")]
+        [Obsolete("This field is no longer used and will be removed in a future version.", true)]
         internal static readonly Dictionary<uint, string> __rpc_name_table = new Dictionary<uint, string>();
 
 #pragma warning restore IDE1006 // restore naming rule violation check

com.unity.netcode.gameobjects/Runtime/Core/NetworkObject.cs

@@ -347,11 +347,7 @@ private void CheckForInScenePlaced()
                     }
                 }
 
-#pragma warning disable CS0618 // Type or member is obsolete
-                // Obsolete with warning means we need the underlying behaviour to keep existing
-                // TODO-3.x: remove in the 3.x branch
-                SetSceneObjectStatus(true);
-#pragma warning restore CS0618 // Type or member is obsolete
+                IsSceneObjectInternal = true;
 
                 // We go ahead and set this for "typical in-scene placed" usage patterns so this is serialized
                 InScenePlaced = true;
@@ -1323,8 +1319,10 @@ public bool HasOwnershipStatus(OwnershipStatus status)
         /// This method is marked for deprecation.<br />
         /// Use <see cref="InScenePlaced"/> instead.
         /// </remarks>
-        [Obsolete("Use InScenePlaced instead")]
-        public bool? IsSceneObject { get; internal set; }
+        internal bool? IsSceneObjectInternal { get; set; }
+
+        [Obsolete("Use InScenePlaced instead", true)]
+        public bool? IsSceneObject { get => IsSceneObjectInternal; internal set => IsSceneObjectInternal = value; }
 
 
         /// <summary>
@@ -1361,10 +1359,10 @@ internal set
         /// </summary>
         /// <remarks>Only use this when using custom scene loading</remarks>
         /// <param name="isSceneObject">When true, marks this as a scene-instantiated object; when false, marks it as runtime-instantiated</param>
-        [Obsolete("SetSceneObjectStatus is now calculated during the build.")]
+        [Obsolete("SetSceneObjectStatus is now calculated during the build.", true)]
         public void SetSceneObjectStatus(bool isSceneObject = false)
         {
-            IsSceneObject = isSceneObject;
+            IsSceneObjectInternal = isSceneObject;
         }
 
         /// <summary>
@@ -1990,11 +1988,7 @@ private void SpawnInternal(bool destroyWithScene, ulong ownerClientId, bool play
                 return;
             }
 
-            // Calculate the legacy IsSceneObject value as the public field is obsolete with warning
-            // We can't break the public behavior of the field.
-#pragma warning disable CS0618 // Type or member is obsolete
-            var legacyIsSceneObject = IsSceneObject.HasValue && IsSceneObject.Value;
-#pragma warning restore CS0618 // Type or member is obsolete
+            var legacyIsSceneObject = IsSceneObjectInternal.HasValue && IsSceneObjectInternal.Value;
 
             // If the initial state of the GameObject was disabled and InScenePlaced is marked,
             // then spawn it as in-scene placed.

com.unity.netcode.gameobjects/Runtime/Exceptions/NotListeningException.cs

@@ -5,7 +5,7 @@ namespace Unity.Netcode
     /// <summary>
     /// Exception thrown when the operation require NetworkManager to be listening.
     /// </summary>
-    [Obsolete("Not used anymore.")]
+    [Obsolete("Not used anymore.", true)]
     public class NotListeningException : Exception
     {
         /// <summary>

com.unity.netcode.gameobjects/Runtime/NetworkVariable/Collections/NetworkList.cs

@@ -686,7 +686,7 @@ private void HandleAddListEvent(NetworkListEvent<T> listEvent)
         /// <summary>
         /// This method should not be used. It is left over from a previous interface
         /// </summary>
-        [Obsolete("This property is no longer used and will be removed in a future version.")]
+        [Obsolete("This property is no longer used and will be removed in a future version.", true)]
         public int LastModifiedTick => NetworkTickSystem.NoTick;
 
         /// <summary>