-
Notifications
You must be signed in to change notification settings - Fork 444
Open
Labels
Area: CalcPertains to calculationsPertains to calculationsArea: XarrayPertains to xarray integrationPertains to xarray integrationType: EnhancementEnhancement to existing functionalityEnhancement to existing functionality
Milestone
Description
laplacian is implemented naively and just sums the second derivative across the selected dimensions, which is all of them by default. When given an xarray, we could:
- skip any dimension that doesn't have dimensionality of length.
- skip any dimension that has dimensionality of time (what about pressure?)
Noted in this Stack Overflow question. I'm not sure if there are downsides, but the current failure mode of a DimensionalityError is a bit tricky to decipher.
We should also update the docs to reflect the limitations and added behavior.
Metadata
Metadata
Assignees
Labels
Area: CalcPertains to calculationsPertains to calculationsArea: XarrayPertains to xarray integrationPertains to xarray integrationType: EnhancementEnhancement to existing functionalityEnhancement to existing functionality