From 144f30314619839f44fbccf3ed94175a4fb5d57f Mon Sep 17 00:00:00 2001
From: Freddie <freddie@thing.engineering>
Date: Sun, 29 Mar 2026 09:44:44 -0700
Subject: [PATCH] Don't push invalid collectors into recipes characters

---
 .../components/professions/recipes/View.svelte    | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/apps/frontend/components/professions/recipes/View.svelte b/apps/frontend/components/professions/recipes/View.svelte
index cde9ff1f1..93d7e1dae 100644
--- a/apps/frontend/components/professions/recipes/View.svelte
+++ b/apps/frontend/components/professions/recipes/View.svelte
@@ -42,11 +42,12 @@
         characters = [];
         const collectorIds =
             settingsState.value.professions.collectingCharactersV2?.[profession.id] || [];
-        if (collectorIds.length > 0) {
+        const validCollectors = collectorIds
+            .map((collectorId) => userState.general.characterById[collectorId])
+            .filter((char) => !!char);
+        if (validCollectors.length > 0) {
             characters.push(null);
-            characters.push(
-                ...collectorIds.map((collectorId) => userState.general.characterById[collectorId])
-            );
+            characters.push(...validCollectors);
         }
 
         const professionCharacters = userState.general.visibleCharacters.filter((char) =>
@@ -171,7 +172,7 @@
                 >
             </th>
             {#each characters as character}
-                {#if character !== null}
+                {#if character}
                     <th class="character-icon">
                         <div class="faction{character.faction}">
                             <ClassIcon
@@ -207,8 +208,8 @@
                 </tr>
 
                 {#each abilities as ability}
-                    {@const recipes = wowthingData.static.skillLineAbilityItems[ability.id]}
-                    {@const recipeItem = wowthingData.items.items[recipes?.[0]]}
+                    {@const recipes = wowthingData.static.skillLineAbilityItems[ability.id] || []}
+                    {@const recipeItem = wowthingData.items.items[recipes[0]]}
                     <tr data-id={ability.id}>
                         <td class="source">
                             {#if recipeItem}