Skip to content

Commit f742dec

Browse files
committed
fix: restore macOS integration CI
1 parent 7ee5d7f commit f742dec

5 files changed

Lines changed: 14 additions & 6 deletions

File tree

AGENTS.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,11 @@ The integration suite downloads/caches VS Code builds under `.vscode-test/` (git
3737
`@vscode/test-electron`, launches a real Extension Development Host, and needs a display on Linux
3838
(CI starts Xvfb for it).
3939

40+
Keep `@vscode/test-electron` at **3.1.0 or newer**. VS Code 1.110 renamed the macOS executable from
41+
`Electron` to the product name, and the compatibility symlink was removed in July 2026. Older test
42+
harnesses still hard-code `Contents/MacOS/Electron` and fail with `ENOENT` on Apple Silicon runners
43+
before the integration suite can start.
44+
4045
**Never assert on `vscode.window.activeTerminal`.** It only follows `terminal.show()` when the window
4146
holds real OS focus, and a headless macOS runner will not move focus between a terminal in the editor
4247
area (where launches land, since `terminalLocation` defaults to `beside`) and one in the panel. For

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ All notable changes to this project are documented here. The format is based on
99

1010
### Fixed
1111

12+
- Updated the VS Code integration-test harness for the current macOS app executable layout, restoring
13+
CI on Apple Silicon runners after the legacy `Electron` compatibility path was removed upstream.
1214
- Preserved a favorite when its built-in preset is hidden but a custom agent override with the same
1315
id remains available.
1416
- Escaped backslashes before Markdown delimiters in Agent Doctor reports, preventing version output

package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -565,7 +565,7 @@
565565
"devDependencies": {
566566
"@types/node": "^22.0.0",
567567
"@types/vscode": "1.93.0",
568-
"@vscode/test-electron": "^2.5.2",
568+
"@vscode/test-electron": "^3.1.0",
569569
"@vscode/vsce": "^3.0.0",
570570
"typescript": "^7.0.2"
571571
}

test/metadata.test.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,7 @@ test('package scripts use deterministic local tooling entry points', () => {
217217
assert.equal(packageJson.scripts.compile, 'node ./node_modules/typescript/bin/tsc -p . --pretty false');
218218
assert.equal(packageJson.scripts.package, 'node ./node_modules/@vscode/vsce/vsce package');
219219
assert.match(packageJson.scripts.check, /vsce ls$/);
220+
assert.equal(packageJson.devDependencies['@vscode/test-electron'], '^3.1.0');
220221
});
221222

222223
test('extension keeps Marketplace, sidebar, and toolbar artwork packaged', () => {

0 commit comments

Comments
 (0)