Add Apple Music and YouTube Music search options with per-service settings toggles#76
Merged
Merged
Conversation
…ttings toggles Agent-Logs-Url: https://github.com/TheJoeFin/Trdo/sessions/dac8c98c-2c5e-4f5f-bf1b-cd721868e8db Co-authored-by: TheJoeFin <7809853+TheJoeFin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add configurable search options for music services
Add Apple Music and YouTube Music search options with per-service settings toggles
Apr 1, 2026
Added new SVG files: apple_music.svg, discogs.svg, and ytmusic.svg. These files provide vector logo assets for Apple Music, Discogs, and YouTube Music, with discogs.svg featuring detailed paths and gradients.
- Use SVG icons for all music search services for visual consistency - Add horizontally scrollable search links with settings button - Centralize Apple Music search logic with region-aware URLs - Redesign SettingsPage for per-service music search toggles - Raise MusicSearchServicesChanged event for real-time UI updates - Update NowPlayingViewModel and FavoritesPage to react to service changes - Refactor Apple Music search to always use web, not app - Improve XAML formatting and UI alignment - Add and include new SVG assets for Apple Music, Discogs, YouTube Music
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the existing Spotify/Discogs search integrations to include Apple Music and YouTube Music, with a new Settings section to individually enable/disable each of the four services.
Changes
New search services
itmss:URI (Windows app), falls back tohttps://music.apple.com/search?term=…https://music.youtube.com/search?q=…Settings persistence (
SettingsService)IsSpotifyEnabled,IsDiscogsEnabled,IsAppleMusicEnabled,IsYouTubeMusicEnabled— all defaulttrueGetBoolSetting/SetBoolSettinghelpers to reduce boilerplateNow Playing page
NowPlayingViewModelgainsSearchOnAppleMusic(),SearchOnYouTubeMusic(), andIsXxxEnabledpassthrough propertiesNowPlayingPage.xamlnow bindVisibilityto their respectiveViewModel.IsXxxEnabledFavorites page
HyperlinkButtons added to the DataTemplate expanded row, each with anx:NameFavoritesListView_SelectionChangedcalls a newSetButtonVisibility()helper that uses the existingFindDescendantmechanism to apply per-service visibility fromSettingsServiceat expansion timeSettings page
New Music search services section with a
ToggleSwitch+ description row for each service, bound two-way toSettingsViewModel.IsXxxEnabledproperties.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
ndavsblobprodwus219.blob.core.windows.net/usr/bin/dotnet dotnet restore --no-dependencies /tmp/codeql-scratch-09a801a7dd23cb56/dbs/csharp/working/7308510B18BD5F018EBF4978576AFCBB/missingpackages_workingdir --packages /tmp/codeql-scratch-09a801a7dd23cb56/dbs/csharp/working/missingpackages /p:DisableImplicitNuGetFallbackFolder=true --verbosity normal --configfile /tmp/codeql-scratch-09a801a7dd23cb56/dbs/csharp/working/nugetconfig/nuget.config --force(dns block)s8nvsblobprodwus2158.blob.core.windows.net/usr/bin/dotnet dotnet build Trdo.slnx --configuration Release -p:EnableWindowsTargeting=true(dns block)If you need me to access, download, or install something from one of these locations, you can either: