Skip to content

[P3][Tier-1] IUR adapter prop-fallback leaks internal attributes into props (audit B7) #156

Description

@ty13r

Severity: P3 (semantic-fidelity smell) · Tier-1 (mechanical)
Co-maintained repo (Pascal = architect).
Location: lib/ash_ui/rendering/iur_adapter.ex:96

convert_element does props = if map_size(element.props || %{}) > 0, do: element.props, else: element.attributes. When an element legitimately has empty props, the entire internal attributes map is substituted as props and flows into base_attributes, surfacing compiler-internal keys in the canonical output. Low impact (extra keys) but a Screen→IUR fidelity smell.

Fix: fall back to %{} rather than element.attributes, or whitelist the carried-over keys.

2026-05-28 cross-repo review — see ariston-ui docs/audits/cross-repo-review-2026-05-28.md (finding B7).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions