Skip to content

[P2][Tier-2] Bidirectional write path skips binding-level write authorization (audit B3) #152

Description

@ty13r

Severity: P2 (security — binding contract) · Tier-2 (Pascal review)
Co-maintained repo (Pascal = architect).
Location: lib/ash_ui/runtime/bidirectional_binding.ex:58-74 + lib/ash_ui/liveview/event_handler.ex:359-364

write_binding/4 runs validate → sanitize → ResourceAccess.write_field and never calls Runtime.check_write_access/2 or BindingPolicy.can_write?/2, so the binding's own read_only flag, source-writability, and screen-ownership gates (REQ-AUTH-005) are skipped. The target resource's own Ash policies still run, so it isn't a blanket bypass — but a binding declared read_only stays writable whenever the underlying resource policy permits, defeating the documented binding contract.

Fix: gate write_binding with Runtime.check_write_access(user, binding) before update_resource.

2026-05-28 cross-repo review — see ariston-ui docs/audits/cross-repo-review-2026-05-28.md (finding B3).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions