refactor(resources): extract shared sync/async helpers (#46) (#71)

Issue #46: every body-endpoint method had a sync+async pair that differed
only by `def` vs `async def` and `self._post(...)` vs `await self._post(...)`.
The dispatcher logic (`_check_request_exclusive` + model construction +
`model_dump(...)`) was duplicated verbatim across the two classes, so each
new kwarg had to be added in two places.

Conservative dedup (option 1 in the issue): pull the identical parts of each
method-pair into module-level helpers; both sync and async methods call them.

- _build_*_body(...) helpers: dispatcher inputs (request | individual kwargs)
  → dict ready for transport. Owns the exclusive-arg check, the model
  construction, and the `model_dump(...)` serialization.
- Per-resource query-param builders for GET-list endpoints whose param dicts
  appeared 4× (sync list, sync list_all, async list, async list_all).
- _parse_orderbook + _parse_queue_position response helpers in markets/orders.

What stays per-class (unchanged): method signatures, @overload stubs from
#69 (per-class user-facing typed surface), transport call sites, return-type
wrapping. The dual-transport architecture and `async for` ergonomics are
preserved.

Files refactored: orders, api_keys, communications, multivariate,
order_groups, subaccounts (high-payoff body-endpoint resources) plus
markets, events, historical, series, portfolio, fcm, milestones
(meaningful GET-list dedup). incentive_programs and structured_targets
are left as-is — too small for a helper to be cleaner than the inline
`_params(...)`.

Notes
- subaccounts.transfer: UUID coercion stays inside _build_transfer_body
  (was duplicated across sync+async); behavior identical.
- multivariate.lookup_tickers: the sync `if data is None: raise RuntimeError`
  spec-drift guard is preserved on sync only (async never had it; this
  is a latent inconsistency, not in scope to fix here).

Gates
- ruff: clean
- mypy --strict: clean (75 files)
- pytest (unit): 1405 passed, 48 skipped (no test changes)

Closes #46

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: TexasCoding

kalshi/resources/api_keys.py

@@ -3,7 +3,7 @@
 from __future__ import annotations
 
 import builtins
-from typing import overload
+from typing import Any, overload
 
 from kalshi.models.api_keys import (
     CreateApiKeyRequest,
@@ -18,6 +18,46 @@
     _check_request_exclusive,
 )
 
+# Shared request-body builders (issue #46).
+
+
+def _build_create_api_key_body(
+    request: CreateApiKeyRequest | None,
+    *,
+    name: str | None,
+    public_key: str | None,
+    scopes: builtins.list[str] | None,
+) -> dict[str, Any]:
+    _check_request_exclusive(
+        request, name=name, public_key=public_key, scopes=scopes,
+    )
+    if request is None:
+        if name is None or public_key is None:
+            raise TypeError(
+                "create() requires `name` and `public_key` "
+                "(or pass `request=...`)"
+            )
+        request = CreateApiKeyRequest(
+            name=name, public_key=public_key, scopes=scopes,
+        )
+    return request.model_dump(exclude_none=True, by_alias=True, mode="json")
+
+
+def _build_generate_api_key_body(
+    request: GenerateApiKeyRequest | None,
+    *,
+    name: str | None,
+    scopes: builtins.list[str] | None,
+) -> dict[str, Any]:
+    _check_request_exclusive(request, name=name, scopes=scopes)
+    if request is None:
+        if name is None:
+            raise TypeError(
+                "generate() requires `name` (or pass `request=...`)"
+            )
+        request = GenerateApiKeyRequest(name=name, scopes=scopes)
+    return request.model_dump(exclude_none=True, by_alias=True, mode="json")
+
 
 class ApiKeysResource(SyncResource):
     """Sync API keys resource.
@@ -51,19 +91,9 @@ def create(
         scopes: builtins.list[str] | None = None,
     ) -> CreateApiKeyResponse:
         self._require_auth()
-        _check_request_exclusive(
+        body = _build_create_api_key_body(
             request, name=name, public_key=public_key, scopes=scopes,
         )
-        if request is None:
-            if name is None or public_key is None:
-                raise TypeError(
-                    "create() requires `name` and `public_key` "
-                    "(or pass `request=...`)"
-                )
-            request = CreateApiKeyRequest(
-                name=name, public_key=public_key, scopes=scopes,
-            )
-        body = request.model_dump(exclude_none=True, by_alias=True, mode="json")
         data = self._post("/api_keys", json=body)
         return CreateApiKeyResponse.model_validate(data)
 
@@ -84,14 +114,7 @@ def generate(
         scopes: builtins.list[str] | None = None,
     ) -> GenerateApiKeyResponse:
         self._require_auth()
-        _check_request_exclusive(request, name=name, scopes=scopes)
-        if request is None:
-            if name is None:
-                raise TypeError(
-                    "generate() requires `name` (or pass `request=...`)"
-                )
-            request = GenerateApiKeyRequest(name=name, scopes=scopes)
-        body = request.model_dump(exclude_none=True, by_alias=True, mode="json")
+        body = _build_generate_api_key_body(request, name=name, scopes=scopes)
         data = self._post("/api_keys/generate", json=body)
         return GenerateApiKeyResponse.model_validate(data)
 
@@ -127,19 +150,9 @@ async def create(
         scopes: builtins.list[str] | None = None,
     ) -> CreateApiKeyResponse:
         self._require_auth()
-        _check_request_exclusive(
+        body = _build_create_api_key_body(
             request, name=name, public_key=public_key, scopes=scopes,
         )
-        if request is None:
-            if name is None or public_key is None:
-                raise TypeError(
-                    "create() requires `name` and `public_key` "
-                    "(or pass `request=...`)"
-                )
-            request = CreateApiKeyRequest(
-                name=name, public_key=public_key, scopes=scopes,
-            )
-        body = request.model_dump(exclude_none=True, by_alias=True, mode="json")
         data = await self._post("/api_keys", json=body)
         return CreateApiKeyResponse.model_validate(data)
 
@@ -162,14 +175,7 @@ async def generate(
         scopes: builtins.list[str] | None = None,
     ) -> GenerateApiKeyResponse:
         self._require_auth()
-        _check_request_exclusive(request, name=name, scopes=scopes)
-        if request is None:
-            if name is None:
-                raise TypeError(
-                    "generate() requires `name` (or pass `request=...`)"
-                )
-            request = GenerateApiKeyRequest(name=name, scopes=scopes)
-        body = request.model_dump(exclude_none=True, by_alias=True, mode="json")
+        body = _build_generate_api_key_body(request, name=name, scopes=scopes)
         data = await self._post("/api_keys/generate", json=body)
         return GenerateApiKeyResponse.model_validate(data)