fix: add to times crafted statistics correctly when removing items from machines

Author: Roelymole

src/main/java/dev/galacticraft/machinelib/api/menu/ConfiguredMenu.java

@@ -35,6 +35,7 @@
 import dev.galacticraft.machinelib.api.storage.slot.ResourceSlot;
 import dev.galacticraft.machinelib.api.transfer.ResourceFlow;
 import dev.galacticraft.machinelib.api.transfer.ResourceType;
+import dev.galacticraft.machinelib.api.transfer.TransferType;
 import dev.galacticraft.machinelib.api.util.BlockFace;
 import dev.galacticraft.machinelib.api.util.ItemStackUtil;
 import dev.galacticraft.machinelib.impl.compat.vanilla.StorageSlot;
@@ -193,10 +194,15 @@ public boolean stillValid(Player player) {
         Slot slot = this.slots.get(slotId);
 
         // move from machine -> player
-        if (slotId < this.internalSlots) {
-            assert slot instanceof StorageSlot;
-            this.quickMoveIntoPlayerInventory(((StorageSlot) slot).getWrapped());
-            return slot.getItem();
+        if (slotId < this.internalSlots && slot instanceof StorageSlot storageSlot) {
+            ItemResourceSlot itemSlot = storageSlot.getWrapped();
+            ItemStack original = storageSlot.getItem().copy();
+            this.quickMoveIntoPlayerInventory(itemSlot);
+            ItemStack itemStack = storageSlot.getItem();
+            if (itemSlot.transferMode() == TransferType.OUTPUT) {
+                storageSlot.onQuickCraft(itemStack, original);
+            }
+            return itemStack;
         }
 
         // move from player -> machine

src/main/java/dev/galacticraft/machinelib/impl/compat/vanilla/StorageSlot.java

@@ -25,6 +25,7 @@
 import com.mojang.datafixers.util.Pair;
 import dev.galacticraft.machinelib.api.storage.slot.ItemResourceSlot;
 import dev.galacticraft.machinelib.api.storage.slot.display.ItemSlotDisplay;
+import dev.galacticraft.machinelib.api.transfer.TransferType;
 import dev.galacticraft.machinelib.api.util.ItemStackUtil;
 import dev.galacticraft.machinelib.impl.util.Utils;
 import net.minecraft.core.component.DataComponentPatch;
@@ -150,9 +151,17 @@ public void onTake(Player player, ItemStack stack) {
         if (this.player.getUUID().equals(player.getUUID())) this.checkTakeAchievements(stack);
     }
 
+    @Override
+    protected void onQuickCraft(ItemStack stack, int n) {
+        assert stack.getCount() == n;
+        this.checkTakeAchievements(stack);
+    }
+
     @Override
     protected void checkTakeAchievements(ItemStack stack) {
         super.checkTakeAchievements(stack);
+        if (this.slot.transferMode() != TransferType.OUTPUT) return;
+
         stack.onCraftedBy(this.player.level(), this.player, stack.getCount());
         Set<ResourceLocation> recipes = this.getWrapped().takeRecipes();
         if (recipes != null) {