Replies: 1 comment 1 reply
-
|
I am unable to create a PR as I am not flagged as a collaborator on the project. That said I have pushed up a fix here that is ready to be PRed, reviewed, and merged. TestingAutomatedpnpm install
pnpm exec playwright install chromium
pnpm run build
pnpm run build:all
pnpm run vite-ecosystem-ci:build
pnpm run test:eslint
pnpm run test:types
pnpm --filter @tanstack/router-core run test:types:ts55;
pnpm --filter @tanstack/router-core run test:types:ts56;
pnpm --filter @tanstack/router-core run test:types:ts57;
pnpm --filter @tanstack/router-core run test:types:ts58;
pnpm --filter @tanstack/router-core run test:types:ts59;
pnpm --filter @tanstack/router-core run test:types:ts60;
pnpm run test:unit;
pnpm --filter @tanstack/router-plugin run test:unit;
pnpm --filter @tanstack/vue-router run test:unit:ui;
pnpm run test:build;
pnpm run test:e2e;
pnpm run benchmark:bundle-size;
pnpm run benchmark:client-nav; # one test failed due to some unrelated nav error
# FAIL @benchmarks/client-nav (solid) speed.bench.ts [ solid/speed.bench.ts ]
# Error: Cannot find module '/Users/praybh/Desktop/router/benchmarks/client-nav/solid/vitest.setup.ts'
pnpm run benchmark:ssr;
pnpm --filter @benchmarks/client-nav run test:perf:react;
pnpm --filter @benchmarks/client-nav run test:perf:solid;
pnpm --filter @benchmarks/client-nav run test:perf:vue;
pnpm run test:docs;
pnpm run gpt-generate;
pnpm run labeler-generate;
pnpm run cleanup-empty-packages;
pnpm run set-ts-version 5.8;Manual1. build the tgzpnpm --filter @tanstack/router-plugin build
cd packages/router-plugin
pnpm pack --pack-destination /tmp2. sample bun project with all of the different types of file system routing |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
What do you think adding a new router-plugin for bun bundler?
Current plugins seem based on unplugin, since v3 unplugin has added support for bun unjs/unplugin#539 so it should be not so complicated to add support for bun.
If you think it is a good idea I can try submitting a pull request!
Beta Was this translation helpful? Give feedback.
All reactions