From 72365615e80586efbc1917092355b6a8fa829cbb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ng=C3=B4=20Qu=E1=BB=91c=20=C4=90=E1=BA=A1t?= Date: Thu, 14 May 2026 13:04:45 +0700 Subject: [PATCH] fix: correct CockroachDB supportsSchemaEditing test, drop unused loggers --- Plugins/PostgreSQLDriverPlugin/CockroachPluginDriver.swift | 3 --- Plugins/PostgreSQLDriverPlugin/LibPQDriverCore.swift | 3 --- TableProTests/Models/DatabaseTypeCockroachDBTests.swift | 4 ++-- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/Plugins/PostgreSQLDriverPlugin/CockroachPluginDriver.swift b/Plugins/PostgreSQLDriverPlugin/CockroachPluginDriver.swift index 1417256c7..2d6cbb261 100644 --- a/Plugins/PostgreSQLDriverPlugin/CockroachPluginDriver.swift +++ b/Plugins/PostgreSQLDriverPlugin/CockroachPluginDriver.swift @@ -9,14 +9,11 @@ // import Foundation -import os import TableProPluginKit final class CockroachPluginDriver: LibPQBackedDriver, @unchecked Sendable { let core: LibPQDriverCore - private static let logger = Logger(subsystem: "com.TablePro.PostgreSQLDriver", category: "CockroachPluginDriver") - private var cachedServerVersion: String? var capabilities: PluginCapabilities { diff --git a/Plugins/PostgreSQLDriverPlugin/LibPQDriverCore.swift b/Plugins/PostgreSQLDriverPlugin/LibPQDriverCore.swift index 84979e0df..d5049a14e 100644 --- a/Plugins/PostgreSQLDriverPlugin/LibPQDriverCore.swift +++ b/Plugins/PostgreSQLDriverPlugin/LibPQDriverCore.swift @@ -7,12 +7,9 @@ // import Foundation -import os import TableProPluginKit final class LibPQDriverCore: @unchecked Sendable { - private static let logger = Logger(subsystem: "com.TablePro.PostgreSQLDriver", category: "LibPQDriverCore") - private let config: DriverConnectionConfig private var libpqConnection: LibPQPluginConnection? diff --git a/TableProTests/Models/DatabaseTypeCockroachDBTests.swift b/TableProTests/Models/DatabaseTypeCockroachDBTests.swift index 84835da9c..5ad8a4f71 100644 --- a/TableProTests/Models/DatabaseTypeCockroachDBTests.swift +++ b/TableProTests/Models/DatabaseTypeCockroachDBTests.swift @@ -32,9 +32,9 @@ struct DatabaseTypeCockroachDBTests { #expect(DatabaseType.cockroachdb.supportsForeignKeys == true) } - @Test("supportsSchemaEditing is true") + @Test("supportsSchemaEditing is false (no driver-side DDL generators)") func supportsSchemaEditing() { - #expect(DatabaseType.cockroachdb.supportsSchemaEditing == true) + #expect(DatabaseType.cockroachdb.supportsSchemaEditing == false) } @Test("iconName is cockroachdb-icon")