Skip to content

Commit 92e134e

Browse files
authored
fix(datagrid): label cell-inspector field editors for VoiceOver (#1490) (#1509)
Signed-off-by: Ngô Quốc Đạt <datlechin@gmail.com>
1 parent adddf11 commit 92e134e

2 files changed

Lines changed: 8 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
3030

3131
### Fixed
3232

33+
- VoiceOver now reads the column name and current value for each field editor in the cell inspector. (#1490)
3334
- VoiceOver announces the active tab title when you switch between window tabs. (#1490)
3435
- Opening a query tab no longer pulls keyboard focus away from the sidebar or another control; the editor takes focus only when nothing else holds it. VoiceOver now labels the SQL editor and the Clear and Format buttons. (#1490)
3536
- The connection form opens with the Name field focused, Return or the Down arrow in the welcome search moves to the connection list, and focus returns to the list after a sheet closes, so you can set up a connection without the mouse. (#1490)

TablePro/Views/RightSidebar/EditableFieldView.swift

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,14 @@ internal struct FieldDetailView: View {
120120

121121
// MARK: - Editor Dispatch
122122

123-
@ViewBuilder
124123
private func resolvedEditor(for kind: FieldEditorKind) -> some View {
124+
editorContent(for: kind)
125+
.accessibilityLabel(context.columnName)
126+
.accessibilityValue(context.value.wrappedValue)
127+
}
128+
129+
@ViewBuilder
130+
private func editorContent(for kind: FieldEditorKind) -> some View {
125131
switch kind {
126132
case .json:
127133
JsonEditorView(context: context, onExpand: onExpand, onPopOut: onPopOut)

0 commit comments

Comments
 (0)