Skip to content

Commit 87e9075

Browse files
committed
refactor(hig): clean up server dashboard split-view wrapper per review
1 parent fc11d3b commit 87e9075

1 file changed

Lines changed: 4 additions & 8 deletions

File tree

TablePro/Views/ServerDashboard/ServerDashboardSplitView.swift

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import AppKit
22
import SwiftUI
33

44
struct ServerDashboardSplitView: NSViewControllerRepresentable {
5-
@Bindable var viewModel: ServerDashboardViewModel
5+
let viewModel: ServerDashboardViewModel
66

77
func makeCoordinator() -> Coordinator {
88
Coordinator()
@@ -14,14 +14,11 @@ struct ServerDashboardSplitView: NSViewControllerRepresentable {
1414
splitViewController.splitView.dividerStyle = .thin
1515
splitViewController.splitView.autosaveName = "ServerDashboardSplit"
1616

17-
let panels = orderedPanels()
18-
19-
for panel in panels {
17+
for panel in orderedPanels() {
2018
let item = makeItem(for: panel, coordinator: context.coordinator)
2119
splitViewController.addSplitViewItem(item)
2220
}
2321

24-
context.coordinator.installedPanels = panels
2522
return splitViewController
2623
}
2724

@@ -63,7 +60,7 @@ struct ServerDashboardSplitView: NSViewControllerRepresentable {
6360
let item = NSSplitViewItem(viewController: controller)
6461
item.minimumThickness = 76
6562
item.maximumThickness = 200
66-
item.holdingPriority = NSLayoutConstraint.Priority(260)
63+
item.holdingPriority = .defaultHigh
6764
coordinator.metricsController = controller
6865
return item
6966

@@ -77,7 +74,7 @@ struct ServerDashboardSplitView: NSViewControllerRepresentable {
7774
let item = NSSplitViewItem(viewController: controller)
7875
item.minimumThickness = 100
7976
item.canCollapse = true
80-
item.holdingPriority = NSLayoutConstraint.Priority(255)
77+
item.holdingPriority = .defaultHigh
8178
coordinator.slowQueriesController = controller
8279
return item
8380
}
@@ -87,6 +84,5 @@ struct ServerDashboardSplitView: NSViewControllerRepresentable {
8784
var sessionsController: NSHostingController<SessionsTableView>?
8885
var metricsController: NSHostingController<MetricsBarView>?
8986
var slowQueriesController: NSHostingController<SlowQueryListView>?
90-
var installedPanels: [DashboardPanel] = []
9187
}
9288
}

0 commit comments

Comments
 (0)