refactor(ios): handle every writePermission case in grid save and insert gates

Author: datlechin

TableProMobile/TableProMobile/ViewModels/RowDetailViewModel.swift

@@ -188,13 +188,16 @@ final class RowDetailViewModel {
             primaryKeys: pkValues
         )
 
-        if safeModeLevel.writePermission == .requiresConfirmation {
+        switch safeModeLevel.writePermission {
+        case .blocked:
+            return false
+        case .requiresConfirmation:
             pendingSaveSQL = sql
             pendingWriteConfirmation = true
             return false
+        case .proceed:
+            return await execute(sql: sql, session: session)
         }
-
-        return await execute(sql: sql, session: session)
     }
 
     func executePendingSave() async -> Bool {

TableProMobile/TableProMobile/Views/InsertRowView.swift

@@ -187,13 +187,15 @@ struct InsertRowView: View {
 
         let sql = buildInsertSQL()
 
-        if safeModeLevel.writePermission == .requiresConfirmation {
+        switch safeModeLevel.writePermission {
+        case .blocked:
+            return
+        case .requiresConfirmation:
             pendingInsertSQL = sql
             showInsertConfirmation = true
-            return
+        case .proceed:
+            await executeInsert(sql: sql, session: session)
         }
-
-        await executeInsert(sql: sql, session: session)
     }
 
     private func executePendingInsert() async {

TableProMobile/TableProMobileTests/RowDetailViewModelTests.swift

@@ -164,6 +164,23 @@ struct RowDetailViewModelTests {
         #expect(driver.executedQueries[0].uppercased().hasPrefix("UPDATE"))
     }
 
+    @Test("saveChanges under readOnly never executes")
+    func saveReadOnlyBlocks() async {
+        let driver = MockDatabaseDriver()
+        let vm = RowDetailViewModel(
+            columns: makeColumns(), rows: makeRows(), initialIndex: 0,
+            table: TableInfo(name: "users"), session: makeSession(driver: driver),
+            columnDetails: makeColumns(), safeModeLevel: .readOnly
+        )
+        vm.startEditing()
+        vm.setEditedValue("Charlie", at: 1)
+
+        let success = await vm.saveChanges()
+        #expect(success == false)
+        #expect(vm.pendingWriteConfirmation == false)
+        #expect(driver.executedQueries.isEmpty)
+    }
+
     @Test("saveChanges fails when no primary key value present")
     func saveWithoutPrimaryKey() async {
         let driver = MockDatabaseDriver()